Overhaul quantification optimizations #716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactors mutating methods into string methods for easier unit testing and parity-checking via assertions. Prepares for more efficient implementations.
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
New assertion already paying off Test Case 'AlgorithmTests.testMatchesCollection' started at 2024-02-03 00:43:54.316 |
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
Nate thinks the remaining test failure is due to CI trying to run the tests concurrently |
Contributor
Author
|
Failure appears to be pre-existing, going ahead and merging |
Member
|
@Catfish-Man Err, this is hitting an assert introduced by this PR. Should we revert and fix? edit: I see, that was pre-fix. Let's in general try to get a clean CI before merging though, unless there's an emergency rush. |
Member
|
Is it a problem for tests to run concurrently? Why? |
Contributor
Author
|
Ok. I discussed with Nate first and made sure it passed locally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finishing up @milseman's #710