From b2ec998aec1568d0d29200febb43ffb66866d465 Mon Sep 17 00:00:00 2001 From: Max Desiatov Date: Mon, 7 Apr 2025 17:13:06 +0100 Subject: [PATCH 1/3] Make language checks pass in `dlmalloc.c` --- Guest/Sources/dlmalloc/src/dlmalloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Guest/Sources/dlmalloc/src/dlmalloc.c b/Guest/Sources/dlmalloc/src/dlmalloc.c index a7ade59..1676a64 100644 --- a/Guest/Sources/dlmalloc/src/dlmalloc.c +++ b/Guest/Sources/dlmalloc/src/dlmalloc.c @@ -12,7 +12,7 @@ // WebAssembly doesn't support shrinking linear memory. #define MORECORE_CANNOT_TRIM 1 -// Disable sanity checks to reduce code size. +// Disable checks to reduce code size. #define ABORT __builtin_unreachable() // If threads are enabled, enable support for threads. From d0c36b34c7f77fcf0a9f79f5a50953de82273353 Mon Sep 17 00:00:00 2001 From: Max Desiatov Date: Mon, 7 Apr 2025 17:20:16 +0100 Subject: [PATCH 2/3] Update upstream_malloc.h --- Guest/Sources/dlmalloc/src/upstream_malloc.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Guest/Sources/dlmalloc/src/upstream_malloc.h b/Guest/Sources/dlmalloc/src/upstream_malloc.h index 51463f1..3311fee 100644 --- a/Guest/Sources/dlmalloc/src/upstream_malloc.h +++ b/Guest/Sources/dlmalloc/src/upstream_malloc.h @@ -3131,8 +3131,7 @@ static int init_mparams(void) { } #endif /* WIN32 */ - /* Sanity-check configuration: - size_t must be unsigned and as wide as pointer type. + /* size_t must be unsigned and as wide as pointer type. ints must be at least 4 bytes. alignment must be at least 8. Alignment, min chunk size, and page size must all be powers of 2. From 40c7b3214e5892271fe7ceacd9df449aeec399cb Mon Sep 17 00:00:00 2001 From: Max Desiatov Date: Mon, 7 Apr 2025 17:20:56 +0100 Subject: [PATCH 3/3] Update pull_request.yml --- .github/workflows/pull_request.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml index 0d8c204..8d131bf 100644 --- a/.github/workflows/pull_request.yml +++ b/.github/workflows/pull_request.yml @@ -18,7 +18,7 @@ jobs: with: license_header_check_project_name: "Swift" api_breakage_check_enabled: false - unacceptable_language_check_enabled: false + unacceptable_language_check_enabled: true license_header_check_enabled: false broken_symlink_check_enabled: false format_check_enabled: false