Only rename __DataStorage.replaceBytes symbol on FOUNDATION_FRAMEWORK #1619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test |
parkera
approved these changes
Dec 3, 2025
glessard
reviewed
Dec 3, 2025
Sources/FoundationEssentials/Data/Representations/DataStorage.swift
Outdated
Show resolved
Hide resolved
glessard
approved these changes
Dec 3, 2025
Contributor
|
@swift-ci please test |
…swift Co-authored-by: Guillaume Lessard <glessard@tffenterprises.com>
Contributor
Author
|
@swift-ci please test |
glessard
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use
@_silgen_namehere to rename this symbol to useNSRangeinstead of(Int, Int)because the symbol was originally introduced withNSRangeinstead but we want to use(Int, Int)in source to avoid a dependency onNSRange. However, this current@_silgen_namecauses issues when building the package in some environments because it uses "Foundation" as the module name (instead of "FoundationEssentials"). Since the package (and non-FOUNDATION_FRAMEWORKplatforms) are not ABI stable and don't need to preserve the historic symbol name, we can just only apply@_silgen_namewhen building withFOUNDATION_FRAMEWORKto avoid conflicting definitions when ABI preservation is not required (while still preserving the ABI where it matters).