Skip to content

[SR-1174] [llbuild] Properly escape verbose command descriptions #806

@ddunbar

Description

@ddunbar
Previous ID SR-1174
Radar None
Original Reporter @ddunbar
Type Bug
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s llbuild
Labels Bug, StarterBug
Assignee @aciidb0mb3r
Priority Medium

md5: 9e2bc2a22e36a68f65cc008d340149b7

Issue Description:

llbuild has a number of places where it prints out a command line to the console. When doing so, we should quote the command such that it will execute properly if rerun from the shell, which requires performing shell escaping.

For example:

$ cat t.llbuild 
client:
  name: basic
  version: 0

targets:
  "": ["<dummy>"]

commands:
  C.dummy:
    tool: shell
    args: ["echo", "hello \"world\"!"]
    outputs: ["<dummy>"]

$ llbuild buildsystem build --no-db -f t.llbuild 
echo "hello "world"!"
hello "world"!

The first command printed there echo "hello "world"!" is not escaped properly.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions