Fix package manifest #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@swift-ci please test |
d-ronnqvist
approved these changes
Nov 15, 2021
Contributor
d-ronnqvist
left a comment
d-ronnqvist
left a comment
There was a problem hiding this comment.
Thanks for finding and fixing this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable:
Summary
In current master (c570b58), this package uses swift-argument parser
~> 1.0.1.https://github.com/apple/swift-markdown/blob/c570b5873782f1a1cca5f649ebf1e0bc599bba51/Package.swift#L56
However, Swift 5.5 still uses 0.4.4.
https://github.com/apple/swift-markdown/blob/c570b5873782f1a1cca5f649ebf1e0bc599bba51/Package%40swift-5.5.swift#L58
Because of this, swift-docc fails to resolve dependencies when it is built as other package's dependencies.
Dependencies
Testing
Run tests on Swift 5.5.
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
./bin/testscript and it succeeded