Fix examples in Windows installation options #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevapple
requested review from
0xTim,
alexandersandberg,
daveverwer,
dempseyatgithub,
parispittman,
kaishin,
mschinis,
shahmishal,
TimTr,
tomerd and
cthielen
as code owners
stevapple
changed the title
_winget.md
stevapple
changed the title
|
Anyone to review & merge, perhaps @shahmishal? |
alexandersandberg
approved these changes
Oct 5, 2023
There was a problem hiding this comment.
Looks fine to me, but maybe @compnerd can have a look as well.
compnerd
approved these changes
Oct 6, 2023
|
@swift-ci please test |
|
@shahmishal @tomerd - can we get this merged? |
|
@stevapple @compnerd can you help resolve the merge conflict? |
|
@shahmishal I don't see the resolve conflicts button (maybe because I'm not in the repository committers?). I suspect that the python version is the conflict and the versioning that was merged is the correct version. |
Done. |
|
@swift-ci please test |
|
@shahmishal @tomerd - seems ready to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typos caused by copy-pasting in Windows installation guide, and make some essential improvements.
Motivation:
Address https://forums.swift.org/t/swift-on-windows-guide/67534/8
Modifications:
--id --exactto enforce WinGet package lookup result.Result:
WinGet and Scoop guide should be usable again (and the WinGet part is more robust now).