Use 'current version' instead of specific Xcode version #495
Conversation
The Xcode version is read from the last entry of swift_releases.yml. Multiple Xcode versions can ship with the same Swift version, so the Xcode version displayed can be out of date. The exact Xcode version is not very important to display on the page. So, instead of creating and maintaining an Xcode version data file, the text changes to say 'current version'. Since the user will clicking through to the Mac App Store, they will see the correct version number on the app page in the store. This fixes swiftlang#493.
dempseyatgithub
requested review from
0xTim,
alexandersandberg,
daveverwer,
parispittman,
kaishin,
mschinis,
shahmishal,
TimTr,
tomerd and
cthielen
as code owners
|
Note I also made the change to the macOS install page where a similar thing could happen. Will defer merging to give @shahmishal a chance to take a look. |
|
@swift-ci test please |
|
@swift-ci test |
| @@ -4,7 +4,7 @@ | |||
| <li class="resource featured"> | |||
| <h3>Xcode</h3> | |||
| <p class="description"> | |||
| Download {{ site.data.builds.swift_releases.last.xcode }} which contains the latest Swift release. | |||
There was a problem hiding this comment.
What about Download {{ site.data.builds.swift_releases.last.xcode }} or later contains the latest Swift release
In this example: Xcode 15.1 and 15.2 both have same swift compiler, so we would cover the case where we don't release a newer swift compiler version with a Xcode release.
There was a problem hiding this comment.
@shahmishal Do you mean update the data file 'Xcode' field to 15.2?
There was a problem hiding this comment.
We can keep it to Xcode 15.1, however the text would be
Download {{ site.data.builds.swift_releases.last.xcode }} or later contains the latest Swift release
output:
Download Xcode 15.1 or later contains the latest Swift release
There was a problem hiding this comment.
Thank you for clarifying, I missed the 'or later' in your original post.
So the choice would be between:
"Download Xcode 15.1 or later which contains the latest Swift release."
"Download the current version of Xcode which contains the latest Swift release."
In both cases, the user doesn't know exactly which version of Xcode they are going to get when they click on the link to the Mac App Store.
I think the more general 'current version' reads better and also gives the user a better conceptual idea of what they are doing.
It's probably less important to someone new to Swift what the exact version of Xcode is that they have to download. But probably more important that they are getting the current version of Xcode to get the latest version of Swift.
There was a problem hiding this comment.
Good point, I am ok with using current compared to specific Xcode version.
The values represent the first version of Xcode that version of Swift appeared in, so they are accurate. Potentially the But, it seemed like adding the ongoing maintenance of tracking and updating the file for minor and patch releases of Xcode without new versions of Swift was high compared the minimal benefit of using the correct version number in two descriptive strings on the site. |
The Xcode version is read from the last entry of swift_releases.yml. Multiple Xcode versions can ship with the same Swift version, so the Xcode version displayed can be out of date.
The exact Xcode version is not very important to display on the page. So, instead of creating and maintaining an Xcode version data file, the text changes to say 'current version'.
Since the user will clicking through to the Mac App Store, they will see the correct version number on the app page in the store.
This fixes #493.