Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Download] Add Windows arm64 installer for nightly development snapsh… #698

Merged
merged 3 commits into from
Jul 3, 2024

Conversation

shahmishal
Copy link
Member

…ots (main) branch

Screenshot 2024-06-07 at 12 07 29 AM

@shahmishal
Copy link
Member Author

@swift-ci test

@shahmishal
Copy link
Member Author

shahmishal commented Jun 8, 2024

After running a few test on the Windows arm64 installer, we noticed an issue.

Could not build C module "SwiftShims" - Windows ARM64 Toolchain

simple package with swift package init and then do swift build:

PS C:\Users\plemarquand\WindowsTestApp> swift build
error: 'windowstestapp': Invalid manifest (compiled with: ["C:\\Users\\plemarquand\\AppData\\Local\\Programs\\Swift\\Toolchains\\0.0.0+Asserts\\usr\\bin\\swiftc.exe", "-vfsoverlay", "C:\\Users\\PLEMAR~1\\AppData\\Local\\Temp\\TemporaryDirectory.qxYguG\\vfs.yaml", "-L", "C:\\Users\\plemarquand\\AppData\\Local\\Programs\\Swift\\Toolchains\\0.0.0+Asserts\\usr\\lib\\swift\\pm\\ManifestAPI", "-lPackageDescription", "-sdk", "C:\\Users\\plemarquand\\AppData\\Local\\Programs\\Swift\\Platforms\\0.0.0\\Windows.platform\\Developer\\SDKs\\Windows.sdk", "-libc", "MD", "-I", "C:\\Users\\plemarquand\\AppData\\Local\\Programs\\Swift\\Platforms\\0.0.0\\Windows.platform\\Developer\\Library\\XCTest-development\\usr\\lib\\swift\\windows", "-I", "C:\\Users\\plemarquand\\AppData\\Local\\Programs\\Swift\\Platforms\\0.0.0\\Windows.platform\\Developer\\Library\\XCTest-development\\usr\\lib\\swift\\windows\\aarch64", "-L", "C:\\Users\\plemarquand\\AppData\\Local\\Programs\\Swift\\Platforms\\0.0.0\\Windows.platform\\Developer\\Library\\XCTest-development\\usr\\lib\\swift\\windows\\aarch64", "-use-ld=lld", "-swift-version", "6", "-I", "C:\\Users\\plemarquand\\AppData\\Local\\Programs\\Swift\\Toolchains\\0.0.0+Asserts\\usr\\lib\\swift\\pm\\ManifestAPI", "-package-description-version", "6.0.0", "C:\\Users\\plemarquand\\WindowsTestApp\\Package.swift", "-o", "C:\\Users\\PLEMAR~1\\AppData\\Local\\Temp\\TemporaryDirectory.pJ279F\\windowstestapp-manifest.exe"])
<module-includes>:1:10: note: in file included from <module-includes>:1:
 1 | #include "AssertionReporting.h"
   |          `- note: in file included from <module-includes>:1:
 2 | #include "CoreFoundationShims.h"
 3 | #include "EmbeddedShims.h"

C:\Users\plemarquand\AppData\Local\Programs\Swift\Platforms\0.0.0\Windows.platform\Developer\SDKs\Windows.sdk\usr\lib\swift\shims/AssertionReporting.h:16:10: note: in file included from C:\Users\plemarquand\AppData\Local\Programs\Swift\Platforms\0.0.0\Windows.platform\Developer\SDKs\Windows.sdk\usr\lib\swift\shims/AssertionReporting.h:16:
14 | #define SWIFT_STDLIB_SHIMS_ASSERTIONREPORTING_H_

15 |
16 | #include "SwiftStdint.h"
   |          `- note: in file included from C:\Users\plemarquand\AppData\Local\Programs\Swift\Platforms\0.0.0\Windows.platform\Developer\SDKs\Windows.sdk\usr\lib\swift\shims/AssertionReporting.h:16:
17 | #include "Visibility.h"
18 |

<unknown>:0: error: could not build C module 'SwiftShims'
C:\Users\plemarquand\AppData\Local\Programs\Swift\Platforms\0.0.0\Windows.platform\Developer\SDKs\Windows.sdk\usr\lib\swift\shims/SwiftStdint.h:28:10: error: 'stdint.h' file not found
26 | // __UINTxx_TYPE__ are defined only since Clang 3.5.
27 | #if !defined(__APPLE__) && !defined(__linux__) && !defined(__OpenBSD__) && !defined(__wasi__)
28 | #include <stdint.h>
   |          `- error: 'stdint.h' file not found
29 | typedef int64_t __swift_int64_t;
30 | typedef uint64_t __swift_uint64_t;
error: 'windowstestapp': Invalid manifest (compiled with: ["C:\\Users\\plemarquand\\AppData\\Local\\Programs\\Swift\\Toolchains\\0.0.0+Asserts\\usr\\bin\\swiftc.exe", "-vfsoverlay", "C:\\Users\\PLEMAR~1\\AppData\\Local\\Temp\\TemporaryDirectory.hdpSqm\\vfs.yaml", "-L", "C:\\Users\\plemarquand\\AppData\\Local\\Programs\\Swift\\Toolchains\\0.0.0+Asserts\\usr\\lib\\swift\\pm\\ManifestAPI", "-lPackageDescription", "-sdk", "C:\\Users\\plemarquand\\AppData\\Local\\Programs\\Swift\\Platforms\\0.0.0\\Windows.platform\\Developer\\SDKs\\Windows.sdk", "-libc", "MD", "-I", "C:\\Users\\plemarquand\\AppData\\Local\\Programs\\Swift\\Platforms\\0.0.0\\Windows.platform\\Developer\\Library\\XCTest-development\\usr\\lib\\swift\\windows", "-I", "C:\\Users\\plemarquand\\AppData\\Local\\Programs\\Swift\\Platforms\\0.0.0\\Windows.platform\\Developer\\Library\\XCTest-development\\usr\\lib\\swift\\windows\\aarch64", "-L", "C:\\Users\\plemarquand\\AppData\\Local\\Programs\\Swift\\Platforms\\0.0.0\\Windows.platform\\Developer\\Library\\XCTest-development\\usr\\lib\\swift\\windows\\aarch64", "-use-ld=lld", "-swift-version", "6", "-I", "C:\\Users\\plemarquand\\AppData\\Local\\Programs\\Swift\\Toolchains\\0.0.0+Asserts\\usr\\lib\\swift\\pm\\ManifestAPI", "-package-description-version", "6.0.0", "C:\\Users\\plemarquand\\WindowsTestApp\\Package.swift", "-o", "C:\\Users\\PLEMAR~1\\AppData\\Local\\Temp\\TemporaryDirectory.8LCxeX\\windowstestapp-manifest.exe"])
<module-includes>:1:10: note: in file included from <module-includes>:1:
 1 | #include "AssertionReporting.h"
   |          `- note: in file included from <module-includes>:1:
 2 | #include "CoreFoundationShims.h"
 3 | #include "EmbeddedShims.h"

C:\Users\plemarquand\AppData\Local\Programs\Swift\Platforms\0.0.0\Windows.platform\Developer\SDKs\Windows.sdk\usr\lib\swift\shims/AssertionReporting.h:16:10: note: in file included from C:\Users\plemarquand\AppData\Local\Programs\Swift\Platforms\0.0.0\Windows.platform\Developer\SDKs\Windows.sdk\usr\lib\swift\shims/AssertionReporting.h:16:
14 | #define SWIFT_STDLIB_SHIMS_ASSERTIONREPORTING_H_
15 |
16 | #include "SwiftStdint.h"
   |          `- note: in file included from C:\Users\plemarquand\AppData\Local\Programs\Swift\Platforms\0.0.0\Windows.platform\Developer\SDKs\Windows.sdk\usr\lib\swift\shims/AssertionReporting.h:16:
17 | #include "Visibility.h"
18 |

<unknown>:0: error: could not build C module 'SwiftShims'
C:\Users\plemarquand\AppData\Local\Programs\Swift\Platforms\0.0.0\Windows.platform\Developer\SDKs\Windows.sdk\usr\lib\swift\shims/SwiftStdint.h:28:10: error: 'stdint.h' file not found
26 | // __UINTxx_TYPE__ are defined only since Clang 3.5.
27 | #if !defined(__APPLE__) && !defined(__linux__) && !defined(__OpenBSD__) && !defined(__wasi__)
28 | #include <stdint.h>
   |          `- error: 'stdint.h' file not found
29 | typedef int64_t __swift_int64_t;
30 | typedef uint64_t __swift_uint64_t;

cc: @compnerd

@stevapple
Copy link
Contributor

After running a few test on the Windows arm64 installer, we noticed an issue.

Could not build C module "SwiftShims" - Windows ARM64 Toolchain

simple package with swift package init and then do swift build:

PS C:\Users\plemarquand\WindowsTestApp> swift build
error: 'windowstestapp': Invalid manifest (compiled with: ["C:\\Users\\plemarquand\\AppData\\Local\\Programs\\Swift\\Toolchains\\0.0.0+Asserts\\usr\\bin\\swiftc.exe", "-vfsoverlay", "C:\\Users\\PLEMAR~1\\AppData\\Local\\Temp\\TemporaryDirectory.qxYguG\\vfs.yaml", "-L", "C:\\Users\\plemarquand\\AppData\\Local\\Programs\\Swift\\Toolchains\\0.0.0+Asserts\\usr\\lib\\swift\\pm\\ManifestAPI", "-lPackageDescription", "-sdk", "C:\\Users\\plemarquand\\AppData\\Local\\Programs\\Swift\\Platforms\\0.0.0\\Windows.platform\\Developer\\SDKs\\Windows.sdk", "-libc", "MD", "-I", "C:\\Users\\plemarquand\\AppData\\Local\\Programs\\Swift\\Platforms\\0.0.0\\Windows.platform\\Developer\\Library\\XCTest-development\\usr\\lib\\swift\\windows", "-I", "C:\\Users\\plemarquand\\AppData\\Local\\Programs\\Swift\\Platforms\\0.0.0\\Windows.platform\\Developer\\Library\\XCTest-development\\usr\\lib\\swift\\windows\\aarch64", "-L", "C:\\Users\\plemarquand\\AppData\\Local\\Programs\\Swift\\Platforms\\0.0.0\\Windows.platform\\Developer\\Library\\XCTest-development\\usr\\lib\\swift\\windows\\aarch64", "-use-ld=lld", "-swift-version", "6", "-I", "C:\\Users\\plemarquand\\AppData\\Local\\Programs\\Swift\\Toolchains\\0.0.0+Asserts\\usr\\lib\\swift\\pm\\ManifestAPI", "-package-description-version", "6.0.0", "C:\\Users\\plemarquand\\WindowsTestApp\\Package.swift", "-o", "C:\\Users\\PLEMAR~1\\AppData\\Local\\Temp\\TemporaryDirectory.pJ279F\\windowstestapp-manifest.exe"])
<module-includes>:1:10: note: in file included from <module-includes>:1:
 1 | #include "AssertionReporting.h"
   |          `- note: in file included from <module-includes>:1:
 2 | #include "CoreFoundationShims.h"
 3 | #include "EmbeddedShims.h"

C:\Users\plemarquand\AppData\Local\Programs\Swift\Platforms\0.0.0\Windows.platform\Developer\SDKs\Windows.sdk\usr\lib\swift\shims/AssertionReporting.h:16:10: note: in file included from C:\Users\plemarquand\AppData\Local\Programs\Swift\Platforms\0.0.0\Windows.platform\Developer\SDKs\Windows.sdk\usr\lib\swift\shims/AssertionReporting.h:16:
14 | #define SWIFT_STDLIB_SHIMS_ASSERTIONREPORTING_H_

15 |
16 | #include "SwiftStdint.h"
   |          `- note: in file included from C:\Users\plemarquand\AppData\Local\Programs\Swift\Platforms\0.0.0\Windows.platform\Developer\SDKs\Windows.sdk\usr\lib\swift\shims/AssertionReporting.h:16:
17 | #include "Visibility.h"
18 |

<unknown>:0: error: could not build C module 'SwiftShims'
C:\Users\plemarquand\AppData\Local\Programs\Swift\Platforms\0.0.0\Windows.platform\Developer\SDKs\Windows.sdk\usr\lib\swift\shims/SwiftStdint.h:28:10: error: 'stdint.h' file not found
26 | // __UINTxx_TYPE__ are defined only since Clang 3.5.
27 | #if !defined(__APPLE__) && !defined(__linux__) && !defined(__OpenBSD__) && !defined(__wasi__)
28 | #include <stdint.h>
   |          `- error: 'stdint.h' file not found
29 | typedef int64_t __swift_int64_t;
30 | typedef uint64_t __swift_uint64_t;
error: 'windowstestapp': Invalid manifest (compiled with: ["C:\\Users\\plemarquand\\AppData\\Local\\Programs\\Swift\\Toolchains\\0.0.0+Asserts\\usr\\bin\\swiftc.exe", "-vfsoverlay", "C:\\Users\\PLEMAR~1\\AppData\\Local\\Temp\\TemporaryDirectory.hdpSqm\\vfs.yaml", "-L", "C:\\Users\\plemarquand\\AppData\\Local\\Programs\\Swift\\Toolchains\\0.0.0+Asserts\\usr\\lib\\swift\\pm\\ManifestAPI", "-lPackageDescription", "-sdk", "C:\\Users\\plemarquand\\AppData\\Local\\Programs\\Swift\\Platforms\\0.0.0\\Windows.platform\\Developer\\SDKs\\Windows.sdk", "-libc", "MD", "-I", "C:\\Users\\plemarquand\\AppData\\Local\\Programs\\Swift\\Platforms\\0.0.0\\Windows.platform\\Developer\\Library\\XCTest-development\\usr\\lib\\swift\\windows", "-I", "C:\\Users\\plemarquand\\AppData\\Local\\Programs\\Swift\\Platforms\\0.0.0\\Windows.platform\\Developer\\Library\\XCTest-development\\usr\\lib\\swift\\windows\\aarch64", "-L", "C:\\Users\\plemarquand\\AppData\\Local\\Programs\\Swift\\Platforms\\0.0.0\\Windows.platform\\Developer\\Library\\XCTest-development\\usr\\lib\\swift\\windows\\aarch64", "-use-ld=lld", "-swift-version", "6", "-I", "C:\\Users\\plemarquand\\AppData\\Local\\Programs\\Swift\\Toolchains\\0.0.0+Asserts\\usr\\lib\\swift\\pm\\ManifestAPI", "-package-description-version", "6.0.0", "C:\\Users\\plemarquand\\WindowsTestApp\\Package.swift", "-o", "C:\\Users\\PLEMAR~1\\AppData\\Local\\Temp\\TemporaryDirectory.8LCxeX\\windowstestapp-manifest.exe"])
<module-includes>:1:10: note: in file included from <module-includes>:1:
 1 | #include "AssertionReporting.h"
   |          `- note: in file included from <module-includes>:1:
 2 | #include "CoreFoundationShims.h"
 3 | #include "EmbeddedShims.h"

C:\Users\plemarquand\AppData\Local\Programs\Swift\Platforms\0.0.0\Windows.platform\Developer\SDKs\Windows.sdk\usr\lib\swift\shims/AssertionReporting.h:16:10: note: in file included from C:\Users\plemarquand\AppData\Local\Programs\Swift\Platforms\0.0.0\Windows.platform\Developer\SDKs\Windows.sdk\usr\lib\swift\shims/AssertionReporting.h:16:
14 | #define SWIFT_STDLIB_SHIMS_ASSERTIONREPORTING_H_
15 |
16 | #include "SwiftStdint.h"
   |          `- note: in file included from C:\Users\plemarquand\AppData\Local\Programs\Swift\Platforms\0.0.0\Windows.platform\Developer\SDKs\Windows.sdk\usr\lib\swift\shims/AssertionReporting.h:16:
17 | #include "Visibility.h"
18 |

<unknown>:0: error: could not build C module 'SwiftShims'
C:\Users\plemarquand\AppData\Local\Programs\Swift\Platforms\0.0.0\Windows.platform\Developer\SDKs\Windows.sdk\usr\lib\swift\shims/SwiftStdint.h:28:10: error: 'stdint.h' file not found
26 | // __UINTxx_TYPE__ are defined only since Clang 3.5.
27 | #if !defined(__APPLE__) && !defined(__linux__) && !defined(__OpenBSD__) && !defined(__wasi__)
28 | #include <stdint.h>
   |          `- error: 'stdint.h' file not found
29 | typedef int64_t __swift_int64_t;
30 | typedef uint64_t __swift_uint64_t;

cc: @compnerd

If you were following the existing setup guide, you'll need to notice that for ARM64-native development we need Microsoft.VisualStudio.Component.VC.Tools.ARM64 instead of Microsoft.VisualStudio.Component.VC.Tools.x86.x64. Installing the correct workload should solve the problem.

@compnerd
Copy link
Member

compnerd commented Jun 8, 2024

When trying to smoke test the installer, I noticed an access violation in the frontend. I've not had a chance to try to isolate the cause of it, but would be good to resolve that.

@shahmishal
Copy link
Member Author

@swift-ci test

@shahmishal shahmishal merged commit cd7fa03 into main Jul 3, 2024
2 checks passed
@shahmishal shahmishal deleted the add-arm64-windows-installer branch July 3, 2024 21:48
@finagolfin
Copy link
Contributor

@shahmishal, would be good to automate adding these to the download page too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants