Fix footer position #727
Merged
Fix footer position #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
federicobucchi
requested review from
0xTim,
alexandersandberg,
daveverwer,
dempseyatgithub,
parispittman,
kaishin,
shahmishal and
timsneath
as code owners
|
@swift-ci please test |
0xTim
approved these changes
Jun 20, 2024
alexandersandberg
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
Thanks! Looks good! Tested on mobile as well.
The only thing I noticed is that you will always have a scrolling page on mobile (at least in Safari) due to the vh unit, even if the content doesn't expand outside the viewport. However, this is not an issue as (1) we don't have any pages that have this little content and (2) it's still better than having the footer float in the middle of the page. Just wanted to mention it anyway.
ScreenRecording_06-20-2024.08-02-00_1.MP4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When the content is the page is short, the footer aligns in too high.
Modifications:
Added style changes in _screen.scss
Result:
Before
After