Reduce duplicated code for banners #749
Conversation
rauhul
requested review from
0xTim,
alexandersandberg,
daveverwer,
dempseyatgithub,
parispittman,
kaishin,
shahmishal,
timsneath and
federicobucchi
as code owners
| @@ -0,0 +1 @@ | |||
| @import "elements/banner"; | |||
There was a problem hiding this comment.
Note I plan on moving the grid elements from #742 into this folder
rauhul
force-pushed
the
common-banner-css
branch
from
4888d10
to
b0b0aed
Compare
Unifies the banner and cta css styles used on multiple pages. Moves the element to a common location so the it can be found in the source easily and be reused across pages.
rauhul
force-pushed
the
common-banner-css
branch
from
b0b0aed
to
fe0bb47
Compare
|
@swift-ci test |
|
Do the cherry-picks in this PR include turning the banners on all the pages orange? |
|
@dempseyatgithub nope, I split out the orange into a subclass(?) called ".banner.primary" which is only used on the home page right now. |
alexandersandberg
added
the
workgroup-to-discuss
shahmishal
removed
the
workgroup-to-discuss
|
@rauhul Feel free to merge. |
|
@kaishin unfortunately I cannot merge because I lost "write" and "push" access to this repo after the move to "swiftlang". @swiftlang/contributor-experience how can I regain access? |
|
@rauhul I think you want to reach out to the website workgroup on forums. |
Thanks I started a forum group dm! |
|
Sorry @rauhul I wasn't aware. I will take care of merging in the meantime then 👍 |
Unifies the banner and cta css styles used on multiple pages.
Moves the element to a common location so the it can be found in the
source easily and be reused across pages.