[SR-6190] PackageDescription target generated by SwiftPM should use $(TOOLCHAIN_DIR) in OTHER_SWIFT_FLAGS instead of absolute path

[norio-nomura]

Previous ID	SR-6190
Radar	None
Original Reporter	@norio-nomura
Type	Bug
Status	Resolved
Resolution	Done

Environment

Swift 4.0
swift-DEVELOPMENT-SNAPSHOT-2017-10-17-a

Additional Detail from JIRA

Votes	0
Component/s	Package Manager
Labels	Bug
Assignee	None
Priority	Medium

md5: 05bafd94859d72410122e3e6c227b77d

Issue Description:

TOOLCHAINS=swift swift package generate-xcodeproj generates PackageDescription target with setting:

OTHER_SWIFT_FLAGS = "-swift-version 4 -I /Library/Developer/Toolchains/swift-DEVELOPMENT-SNAPSHOT-2017-10-17-a.xctoolchain/usr/lib/swift/pm/4 -target x86_64-apple-macosx10.10 -sdk /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk"

and this causes error on import PackageDescription with Xcode:

Module compiled with Swift 4.1 cannot be imported in Swift 4.0.1: /Library/Developer/Toolchains/swift-DEVELOPMENT-SNAPSHOT-2017-10-17-a.xctoolchain/usr/lib/swift/pm/4/PackageDescription.swiftmodule

For avoiding this, SwiftPM should use $(TOOLCHAIN_DIR) in OTHER_SWIFT_FLAGS instead of absolute path resolved on running swift package generate-xcodeproj.

TOOLCHAIN_DIR will point suitable path on using Xcode:

$ DEVELOPER_DIR=/Applications/Xcode.app xcodebuild -showBuildSettings|grep -E '\s+TOOLCHAIN_DIR'
    TOOLCHAIN_DIR = /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain
$ DEVELOPER_DIR=/Applications/Xcode-beta.app xcodebuild -showBuildSettings|grep -E '\s+TOOLCHAIN_DIR'
    TOOLCHAIN_DIR = /Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain
$ TOOLCHAINS=swift xcodebuild -showBuildSettings|grep -E '\s+TOOLCHAIN_DIR'
    TOOLCHAIN_DIR = /Library/Developer/Toolchains/swift-4.0-RELEASE.xctoolchain
$ TOOLCHAINS=org.swift.3020171017a xcodebuild -showBuildSettings|grep -E '\s+TOOLCHAIN_DIR'
    TOOLCHAIN_DIR = /Library/Developer/Toolchains/swift-DEVELOPMENT-SNAPSHOT-2017-10-17-a.xctoolchain

[aciidgh]

#1414

[norio-nomura]

I confirmed that this issue has been resolved on swift-4.1-DEVELOPMENT-SNAPSHOT-2018-01-15-a.
Thanks! 🙂