[SR-1187] Add example test to Dealer example

[rballard]

Previous ID	SR-1187
Radar	None
Original Reporter	@rballard
Type	Improvement
Status	Resolved
Resolution	Done

Additional Detail from JIRA

Votes	0
Component/s	Package Manager
Labels	Improvement, StarterBug
Assignee	@abertelrud
Priority	Medium

md5: acc58f7cfd300680265cc96d1f2b46a7

Issue Description:

Our example packages don't currently have any tests. We should have at least one test in the package tree rooted at Dealer; preferably several. Testing is an important feature and our examples should demonstrate this.

Note: the dealer package is https://github.com/apple/example-package-dealer

[masters3d]

I added these PR:
swiftlang/example-package-deckofplayingcards#3
apple/example-package-fisheryates#6
swiftlang/example-package-playingcard#1

I did not add tests to https://github.com/apple/example-package-dealer
but the package still works after the PR have been applied to it.

I did not test on Linux but I did add the necessary code for it to work.

[rballard]

Thanks for doing this, and my apologies that I've left this so long.

Max, can you please review this and accept it if appropriate?

[rballard]

Anders, please review this and pull it in with any needed tweaks if appropriate.

[abertelrud]

Reviewing.

[abertelrud]

The tests look good in general; thanks!

Just a couple of things:
a) In addition to adding the tests, the diffs also slightly change the method names in the examples (e.g. `shuffle`); I think this is fine, but wanted to call it out to make sure it was intentional, since this SR just mentions adding a test
b) Is the change to use lowercase enums to make it conform to the new naming convention? I haven't been following this in detail, but am guessing that's the new convention?
c) The PRs no longer merge cleanly, though, so they would need to be updated to the latest.

Thanks!

[abertelrud]

Again, apologies that this has been sitting in limbo for a long time!

[masters3d]

a) b) these are meant to match the swift API naming guidelines.
c) I created a new PR apple/example-package-fisheryates#6
I believe the others are still good.

[abertelrud]

Great, thanks! I've merged these.