Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.2] Don't pass / as default sysroot on Linux #2807

Merged
merged 1 commit into from
Jul 23, 2020
Merged

[5.2] Don't pass / as default sysroot on Linux #2807

merged 1 commit into from
Jul 23, 2020

Conversation

drexin
Copy link
Contributor

@drexin drexin commented Jul 8, 2020

No description provided.

@drexin drexin requested a review from aciidgh as a code owner July 8, 2020 21:34
@drexin
Copy link
Contributor Author

drexin commented Jul 8, 2020

@swift-ci smoke test

@drexin
Copy link
Contributor Author

drexin commented Jul 8, 2020

@swift-ci smoke test

@drexin drexin changed the title Don't pass / as default sysroot on Linux [5.2] Don't pass / as default sysroot on Linux Jul 8, 2020
@abertelrud
Copy link
Contributor

The build failures looks unrelated, but it would be good to understand what's going on there before merging.

@abertelrud
Copy link
Contributor

Oh, and as this is 5.2, we would need release manager's approval anyway.

@abertelrud
Copy link
Contributor

The build failures seem to be because the test is using the main branch version of the compiler and not the 5.2 version.

@abertelrud abertelrud requested a review from tomerd July 9, 2020 22:29
@abertelrud
Copy link
Contributor

@swift-ci please smoke test

@abertelrud
Copy link
Contributor

Release manager has approved, but looks like the merging is still blocked (seems that @aciidb0mb3r must also approve, as the code owner listed for 5.2?).

@shahmishal
Copy link
Member

@swift-ci test 5.2 macOS

@aciidgh aciidgh merged commit 59866b6 into swiftlang:swift-5.2-branch Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neonichu neonichu neonichu approved these changes

@tomerd tomerd tomerd approved these changes

@aciidgh aciidgh aciidgh approved these changes

@abertelrud abertelrud abertelrud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@drexin @abertelrud @shahmishal @neonichu @tomerd @aciidgh