[5.2] Don't pass / as default sysroot on Linux #2807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci smoke test |
Contributor
Author
|
@swift-ci smoke test |
drexin
changed the title
neonichu
approved these changes
Jul 8, 2020
abertelrud
approved these changes
Jul 9, 2020
Contributor
|
The build failures looks unrelated, but it would be good to understand what's going on there before merging. |
Contributor
|
Oh, and as this is 5.2, we would need release manager's approval anyway. |
Contributor
|
The build failures seem to be because the test is using the main branch version of the compiler and not the 5.2 version. |
tomerd
approved these changes
Jul 9, 2020
Contributor
|
@swift-ci please smoke test |
Contributor
|
Release manager has approved, but looks like the merging is still blocked (seems that @aciidb0mb3r must also approve, as the code owner listed for 5.2?). |
aciidgh
approved these changes
Jul 13, 2020
Member
|
@swift-ci test 5.2 macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.