[5.6] refactor CLI options #4291
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motivation: fix an issue when not all options are presented as expected, and make the code clearer to reason about changes: * rename SwiftToolOptions to GlobalOptions * refactor SwiftToolOptions (GlobalOptions) to multiple groups per domains: locations, caching, logging, build, linker, etc * set GlobalOptions "hiddenFromHelp" flag to false for swift-build, swift-test and swift-package * move enableCodeCoverage from GlobalOptions to TestToolOptions, since they apply there * refactor code that construct test build to pass in more fine grained options rather than take the entire global options model * adjust call sites and test rdar://82658867
tomerd
force-pushed
the
5.6/cli-options-fix
branch
from
3fe2310
to
3d10ed0
Compare
|
@swift-ci smoke test |
abertelrud
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: fix an issue when not all options are presented as expected, and make the code clearer to reason about
changes:
rdar://82658867