Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basics: migrate TSCUtility.SQLite to Basics #5764

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Basics: migrate TSCUtility.SQLite to Basics #5764

merged 1 commit into from
Oct 4, 2022

Conversation

compnerd
Copy link
Member

This moves the SQLite API wrapper to SPM from tools-support-core. There is currently a single user of this API, which is SPM. By migrating the API to SPM we can deprecate the TSC interfaces to prevent new adoption. It also reduces the dependencies on TSCUtility for SPM which works towards the longer term goal of shedding the tools-support-core dependency.

@compnerd
Copy link
Member Author

@swift-ci please smoke test

@compnerd
Copy link
Member Author

This is likely going to break the Windows build - we need to pass some additional parameters to the CMake invocation. I want to verify that the Linux and macOS builds are okay first before doing that change.

tomerd
tomerd reviewed Sep 13, 2022
View reviewed changes
Package.swift Outdated Show resolved Hide resolved
tomerd
tomerd reviewed Sep 13, 2022
View reviewed changes
Sources/CSQLite3/shim.c Outdated Show resolved Hide resolved
@tomerd
Copy link
Contributor

tomerd commented Sep 13, 2022

+1 on deprecating from TSC

@compnerd
Copy link
Member Author

@swift-ci please smoke test

@compnerd
Copy link
Member Author

@swift-ci please smoke test

tomerd
tomerd reviewed Sep 22, 2022
View reviewed changes
Package.swift Outdated Show resolved Hide resolved
@compnerd
Copy link
Member Author

@swift-ci please smoke test

@compnerd
Copy link
Member Author

@swift-ci please smoke test macOS platform

@compnerd
Copy link
Member Author

@swift-ci please smoke test

tomerd
tomerd reviewed Sep 27, 2022
View reviewed changes
Package.swift Show resolved Hide resolved
@compnerd
Basics: migrate TSCUtility.SQLite to Basics
6491ccc 
This moves the SQLite API wrapper to SPM from tools-support-core.  There
is currently a single user of this API, which is SPM.  By migrating the
API to SPM we can deprecate the TSC interfaces to prevent new adoption.
It also reduces the dependencies on `TSCUtility` for SPM which works
towards the longer term goal of shedding the tools-support-core
dependency.
@compnerd
Copy link
Member Author

@swift-ci please smoke test

@compnerd
Copy link
Member Author

Please test with following PRs:
swiftlang/swift#61310

@swift-ci please smoke test Windows platform

@compnerd
Copy link
Member Author

Please test with following PRs:
swiftlang/swift#61310
swiftlang/sourcekit-lsp#640

@swift-ci please smoke test Windows platform

@neonichu
Copy link
Contributor

neonichu commented Oct 3, 2022

@compnerd Is this ready to merge?

@compnerd
Copy link
Member Author

compnerd commented Oct 4, 2022

Thanks for the reminder @neonichu, this is ready to merge. The dependencies have been merged. I'll follow up on the t-s-c deprecation separately. Going to merge this since I assume that the reminder was to go ahead and merge.

@compnerd compnerd merged commit 239f317 into swiftlang:main Oct 4, 2022
@compnerd compnerd deleted the sequel branch October 4, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomerd tomerd tomerd approved these changes

@abertelrud abertelrud Awaiting requested review from abertelrud

@neonichu neonichu Awaiting requested review from neonichu

@elsh elsh Awaiting requested review from elsh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@compnerd @tomerd @neonichu