Fix issue with running test on windows w/no-parallel #8676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daveinglis
requested review from
bkhouri,
bripeticca,
cmcgee1024,
daveyc123,
dschaefer2,
jakepetroules,
owenv,
plemarquand and
shawnhyam
as code owners
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test windows |
bkhouri
approved these changes
May 16, 2025
daveinglis
force-pushed
the
pr/windows_env_fix
branch
from
e10bdbc to
eac75b3
Compare
Contributor
Author
|
@swift-ci test |
daveinglis
force-pushed
the
pr/windows_env_fix
branch
2 times, most recently
from
2652bd7 to
54a7a40
Compare
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test windows |
Contributor
Author
|
@swift-ci test windows self hosted |
Contributor
Author
|
@swift-ci test windows |
daveinglis
force-pushed
the
pr/windows_env_fix
branch
from
54a7a40 to
808eaae
Compare
Contributor
Author
|
@swift-ci test windows |
daveinglis
force-pushed
the
pr/windows_env_fix
branch
from
808eaae to
5ccaeb6
Compare
Contributor
Author
|
@swift-ci test windows |
Contributor
Author
|
@swift-ci test |
1 similar comment
Contributor
Author
|
@swift-ci test |
daveinglis
force-pushed
the
pr/windows_env_fix
branch
from
5ccaeb6 to
d999e35
Compare
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test windows |
1 similar comment
Contributor
Author
|
@swift-ci test windows |
daveinglis
force-pushed
the
pr/windows_env_fix
branch
from
d999e35 to
d087c3f
Compare
Contributor
Author
|
@swift-ci test |
daveinglis
force-pushed
the
pr/windows_env_fix
branch
2 times, most recently
from
261a9fd to
039e842
Compare
Contributor
Author
|
@swift-ci test |
The AsyncProcess Tests were using a TSCTestSupport method to temporarly change the PATH env but seems to have a bug where it removes the variable instead of restoring resulting in any future test needing PATH to fail. This switch it to using the same method that is in SwiftPM Environment.swft
daveinglis
force-pushed
the
pr/windows_env_fix
branch
from
039e842 to
4979efe
Compare
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test windows |
dschaefer2
approved these changes
May 23, 2025
Member
|
Awesome. Thanks @daveinglis! |
jakepetroules
approved these changes
May 23, 2025
Contributor
jakepetroules
left a comment
jakepetroules
left a comment
There was a problem hiding this comment.
Thanks!
Also, the way I solved similar cases for the tests in SwiftBuild was to use @TaskLocal (see SWBUtil/UserDefault.swift), which is like a Swift Concurrency version of thread local storage.
I suggest taking a look at adopting that in Environment next, for a more permanent fix. That'll allow us to just make withCustomEnv / Environment.makeCustom completely thread safe.
Member
|
@swift-ci please test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AsyncProcess Tests were using a TSCTestSupport method to temporarily change the PATH env but seems to have a bug where it removes the variable instead of restoring resulting in any future test needing PATH to fail. This switches it to using the similar method that is in SwiftPM Environment.swift