Pin GitHub actions workflows to a version #9435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinning has a few benefits: - Workflows are more repeatable for a given a commit ID. We know exactly what steps were performed. - Updating the workflows version goes though the PR validation process, so we know whether we want to apply a change to the entire repository. - We avoid potential issues with breaking changes in the upstream workflows.
bkhouri
requested review from
bripeticca,
cmcgee1024,
daveyc123,
dschaefer2,
jakepetroules,
owenv,
plemarquand and
rconnell9
as code owners
Contributor
Author
|
@swift-ci test |
cmcgee1024
approved these changes
Dec 2, 2025
Member
|
Let's hold off. We will need a new tag to fix the Android workflows. |
Member
|
Never mind, we are not using android testing yet. |
shahmishal
approved these changes
Dec 2, 2025
jakepetroules
approved these changes
Dec 2, 2025
Contributor
jakepetroules
left a comment
jakepetroules
left a comment
There was a problem hiding this comment.
LG but please make sure to do the same thing for swift-build.
Also hoping we get swiftlang/github-workflows#198 landed soon.
Contributor
Author
The Swift-build change already landed :) |
bkhouri
added
the
continuous integration/deployment
Contributor
Author
|
Although I am usually against merging changes where builds fails. @MaxDesiatov force merged the PR as this only modifies GitHub Actions, and there were Jenkins jobs failure, which is unrelated to this change. Thanks for force merging, @MaxDesiatov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pinning has a few benefits: