Skip to content

Conversation

@euanh
Copy link
Contributor

@euanh euanh commented Nov 28, 2024

These changes reduce the size of the SDK by 450MB. Not having
to extract and copy this data around slightly speeds up the process
of building an SDK. On my machine

  • Building a Swift 6.0 aarch64 SDK decreased from 23s to 22s
  • Running the EndToEndTests decreased from 32m39s to 32m17s

The EndToEndTests continue to pass after this change.

These changes reduce the size of the SDK by 450MB.   Not having
to extract and copy this data around slightly speeds up the process
of building an SDK.  On my machine

* Building a Swift 6.0 aarch64 SDK decreased from 23s to 22s
* Running the EndToEndTests decreased from 32m39s to 32m17s

The EndToEndTests continue to pass after this change.
@euanh euanh requested a review from MaxDesiatov as a code owner November 28, 2024 17:18
@euanh
Copy link
Contributor Author

euanh commented Nov 28, 2024

@swift-ci test

@euanh
Copy link
Contributor Author

euanh commented Nov 28, 2024

% SWIFT_SDK_GENERATOR_RUN_SLOW_TESTS=1 swift test --disable-swift-testing --filter EndToEndTests
...
Test Suite 'swift-sdk-generatorPackageTests.xctest' passed at 2024-11-28 17:00:47.343.                                         
         Executed 18 tests, with 0 failures (0 unexpected) in 1937.071 (1937.072) seconds                                      
Test Suite 'Selected tests' passed at 2024-11-28 17:00:47.343.                                                                 
         Executed 18 tests, with 0 failures (0 unexpected) in 1937.071 (1937.072) seconds                                      

@euanh euanh added the performance Speeding up SDK generation label Nov 28, 2024
@euanh euanh merged commit e006f30 into swiftlang:main Nov 28, 2024
3 checks passed
@euanh euanh deleted the remove-unneeded-platforms branch November 28, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance Speeding up SDK generation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants