Make some small corrections in the FreeBSD SDK generator #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jakepetroules
commented
Sep 4, 2025
jakepetroules
commented
- Change some shared options' help text to not be Linux-specific
- Note that the default FreeBSD target matches the host arch, not fixed to x86_64
- Spell version option as --freebsd-version, not --free-bsd-version
- Remove --from-swift-toolchain, the --target-swift-package-path option already existed for this purpose
- Emit an error if --host-swift-package-path is given, since this currently has no effect
- Change some shared options' help text to not be Linux-specific - Note that the default FreeBSD target matches the host arch, not fixed to x86_64 - Spell version option as --freebsd-version, not --free-bsd-version - Remove --from-swift-toolchain, the --target-swift-package-path option already existed for this purpose - Emit an error if --host-swift-package-path is given, since this currently has no effect
|
@swift-ci test macOS |
|
@swift-ci test |
|
I'm glad you noticed all this. I was trying it out the other day and noticed most of what you fixed... |
CodingCarpincho
approved these changes
Sep 8, 2025
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.