Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate Doug’s macro examples in swift-syntax/Examples #2026

Closed
ahoppen opened this issue Aug 8, 2023 · 11 comments · Fixed by #2059
Closed

Incorporate Doug’s macro examples in swift-syntax/Examples #2026

ahoppen opened this issue Aug 8, 2023 · 11 comments · Fixed by #2059
Assignees
Labels
good first issue Good for newcomers

Comments

@ahoppen
Copy link
Contributor

ahoppen commented Aug 8, 2023

https://github.com/DougGregor/swift-macro-examples is a great collection of macros. We should move them to the Examples folder in swift-syntax to give them more exposure and make sure they build with recent swift-syntax versions.

@kimdv kimdv added the good first issue Good for newcomers label Aug 8, 2023
@Matejkob
Copy link
Contributor

Matejkob commented Aug 8, 2023

Love it! 🚀💙

@Matejkob
Copy link
Contributor

Matejkob commented Aug 8, 2023

Just to make sure: our goal is not only to add a link to those examples but literally move the whole code and adjust it to global standards, isn't it?

@kimdv
Copy link
Contributor

kimdv commented Aug 8, 2023

I think it's moving the code.
If they are inside the Examples we actually try to compile it. Ensures that they work too, if we change things

Do you want this task, I can assign it to you 🙌

@Matejkob
Copy link
Contributor

Matejkob commented Aug 8, 2023

On one hand, I've been experimenting with Swift macros quite a bit, and I have a few ideas on how to standardize building macros and so forth. However, I don't want to be overly ambitious and take on too many tasks for myself. 😅

@kimdv
Copy link
Contributor

kimdv commented Aug 8, 2023

It's just moving them from Doug's repo to this one 😁

@Matejkob
Copy link
Contributor

Matejkob commented Aug 8, 2023

How about we take it a step further? I've noticed some unresolved issues and PRs on Doug's repo. It might be a good idea to not only transfer the code but also undertake a slight refactor. This way, we ensure everything is not only in one place but also optimized, clear, and up-to-date with the project's standards. I believe this could provide even more value to our community. What do you think? 😅

@kimdv
Copy link
Contributor

kimdv commented Aug 8, 2023

Defiantly it could do that!

I'll assign you if you are up to it?

@ahoppen
Copy link
Contributor Author

ahoppen commented Aug 8, 2023

Improving those examples would be a great task as well. I would prefer to do it in two different steps, though: First, just copy the examples and make sure they build inside the examples folder. We can then discuss improvements to them in follow-up PRs.

@Matejkob
Copy link
Contributor

Matejkob commented Aug 8, 2023

In that case, maybe someone else might be interested in resolving the issue. If no one takes it up by the time I finish all the issues currently assigned to me, I'll grab this one.

@ahoppen
Copy link
Contributor Author

ahoppen commented Aug 8, 2023

Tracked in Apple’s issue tracker as rdar://113567655

@Matejkob
Copy link
Contributor

I'm on it :>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants