Use IdentifierExpr in a couple more places instead of DeclNameArguments
#1950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test macOS |
ahoppen
force-pushed
the
ahoppen/identifierexpr
branch
from
c178ed8
to
3771d3d
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
bnbarham
reviewed
Jul 27, 2023
ahoppen
force-pushed
the
ahoppen/identifierexpr
branch
from
3771d3d
to
0f06c9f
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
bnbarham
approved these changes
Jul 28, 2023
|
woohoo! |
bnbarham
approved these changes
Aug 1, 2023
Comment on lines
17
to
31
| /// A member access can specify argument labels to reference an unapplied of | ||
| /// a specific overload based on its argument labels. For example you can have | ||
| /// ```swift | ||
| /// struct Person { | ||
| /// func consume(drink: Drink) {} | ||
| /// func consume(food: Food) {} | ||
| /// } | ||
| /// ``` | ||
| /// | ||
| /// Then you can use `person.consume(drink:)` to explicitly reference the | ||
| /// consume function that takes a drink. | ||
| /// | ||
| /// In most cases, this is not needed and this initializier creates a member | ||
| /// access that does not contain any argument names like `(drink:)` in the | ||
| /// example above. |
There was a problem hiding this comment.
Suggested change
| /// A member access can specify argument labels to reference an unapplied of | |
| /// a specific overload based on its argument labels. For example you can have | |
| /// ```swift | |
| /// struct Person { | |
| /// func consume(drink: Drink) {} | |
| /// func consume(food: Food) {} | |
| /// } | |
| /// ``` | |
| /// | |
| /// Then you can use `person.consume(drink:)` to explicitly reference the | |
| /// consume function that takes a drink. | |
| /// | |
| /// In most cases, this is not needed and this initializier creates a member | |
| /// access that does not contain any argument names like `(drink:)` in the | |
| /// example above. | |
| /// A member access can specify function argument labels, which is required when the name would be ambiguous otherwise. For example, given multiple overloads | |
| /// ```swift | |
| /// struct Person { | |
| /// func consume(drink: Drink) {} | |
| /// func consume(food: Food) {} | |
| /// } | |
| /// ``` | |
| /// | |
| /// `consume(drink:)` is required to explicitly reference the consume function that takes a drink. | |
| /// | |
| /// Given how common it is to not need the argument names, this initializer is provided as a convenience to avoid having to create a ``DeclReferenceExpr`` for the member name. |
ahoppen
force-pushed
the
ahoppen/identifierexpr
branch
2 times, most recently
from
695f08f
to
095428d
Compare
|
@swift-ci Please test |
ahoppen
force-pushed
the
ahoppen/identifierexpr
branch
from
095428d
to
bb01f02
Compare
|
@swift-ci Please test |
`DeclName` was only used for attributes and has the same structure as `IdentifierExprSyntax`. Let’s use `IdentifierExprSyntax` instead.
…hPropertyComponentSyntax`
ahoppen
force-pushed
the
ahoppen/identifierexpr
branch
from
bb01f02
to
8d40a59
Compare
|
swiftlang/swift-format#577 @swift-ci Please test Windows |
|
So, wait, what's the difference between |
|
|
|
swiftlang/swift-format#577 @swift-ci Please test macOS |
|
swiftlang/swift-format#577 @swift-ci Please test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeclNamewas essentially a copy ofIdentifierExprthat was just used for attributes. Kill it and replace it withIdentifierExpr.IdentifierExprinImplementAttributeArgumentsSytnax