[SR-904] Allocate closure context for closures passed @noescape on the stack

[aschwaighofer]

Previous ID	SR-904
Radar	None
Original Reporter	@aschwaighofer
Type	Improvement
Status	Resolved
Resolution	Done

Additional Detail from JIRA

Votes	3
Component/s	Compiler
Labels	Improvement
Assignee	@aschwaighofer
Priority	Medium

md5: 2c3144efb6e8219c5cff33bb3da54d1b

is duplicated by:

• SR-7286 non-escaping closures aren't stack allocated

Issue Description:

Closures only passed as @NoEscape arguments should not be allocated on the heap.

[slavapestov]

aschwaighofer@apple.com (JIRA User) Is there a radar for this too?

[aschwaighofer]

There is the related ABI ticket: https://bugs.swift.org/browse/SR-5441.

There is <rdar://problem/19543674>

There is also <rdar://problem/26650253> and https://github.com/aschwaighofer/swift/tree/closure_stack_promo_prototype which is an abandoned (it took a pure SIL optimization approach).

[aschwaighofer]

Fixed by #21933

[aschwaighofer]

I have filed https://bugs.swift.org/browse/SR-9701 for objective-c block arguments

[weissi]

Yaay, that’s awesome!! Thank you