[SR-4050] Can't declare overloaded local func with exact the same name

[rintaro]

Previous ID	SR-4050
Radar	rdar://problem/16866997
Original Reporter	@rintaro
Type	Bug

Environment

Swift version 3.1-dev (LLVM b3c73ec880, Clang ef793ebbfc, Swift 3209b23)
Target: x86_64-unknown-linux-gnu

Additional Detail from JIRA

Votes	0
Component/s	Compiler
Labels	Bug, Parser
Assignee	None
Priority	Medium

md5: 56a12d4a0b3eddbc6b5ba7e786f579a4

Issue Description:

This should compile.

func foo() {
  func local(x: Int) {}
  func local(x: String) {}
  local(x: 12)
}

results:

test.swift:3:8: error: definition conflicts with previous value
  func local(x: String) {}
       ^
test.swift:2:8: note: previous definition of 'local' is here
  func local(x: Int) {}
       ^

[theblixguy]

Is it reasonable to not diagnose functions in ScopeInfo::addToScope? Because, if we have:

func foo() {
  func local(x: Int) {}
  func local(x: Int) {}
  local(x: 12)
}

It will get diagnosed as "ambiguous" in the type checker.