[SR-7261] Compiler crash on switch case with let and var value bindings

[swift-ci]

Previous ID	SR-7261
Radar	rdar://problem/38800528
Original Reporter	damonallison (JIRA User)
Type	Bug
Status	Closed
Resolution	Done

Attachment: Download

Additional Detail from JIRA

Votes	0
Component/s	Compiler
Labels	Bug, CompilerCrash
Assignee	@gregomni
Priority	Medium

md5: d470f571f5745a3d9eab407d950e70d3

Issue Description:

The following code, with `let` and `var` value bindings in the same case causes the swift compiler to `SIGSEGV`.

allidam@chritmaclt5 ~/p/swift-fundamentals> swift
Welcome to Apple Swift version 4.0.3 (swiftlang-900.0.74.1 clang-900.0.39.2). Type :help for assistance.
1> func test() {
2. let name = "test"
3. switch name {
4. case var n where n.count == 10, let n where n == "test":
5. break
6. default:
7. break
8. }
9. }
Stack dump:
0.  While emitting SIL for 'test()' at /var/folders/29/52nb4xys2pxfxhcz8m26xnsc94m_nc/T/repl1-1a96fe..swift:1:1
fish: 'swift' terminated by signal SIGSEGV (Address boundary error)

[belkadan]

cc @gregomni

@swift-ci create

[belkadan]

With asserts:

Assertion failed: (address.isLValue() && "physical lvalue decl ref must evaluate to an address"), function emitLValueForNonMemberVarDecl, file /Volumes/Data/swift-public/swift/lib/SILGen/SILGenLValue.cpp, line 2276.

[gregomni]

Done in #15488

[AnnaZaks]

damonallison (JIRA User), Could you verify if the problem is fixed and if so move the JIRA to "Closed"?
Thanks!
Anna

[swift-ci]

Comment by Damon Allison (JIRA)

Confirmed fixed. Nice work and thank you, @gregomni!

/Users/dra/projects/swift-fundamentals/SwiftFundamentals-Tests/CompilerBugs/SR7874.swift:17:41: error: 'let' pattern binding must match previous 'var' pattern binding
    case var n where n.count == 10, let n:
                                    ~~~ ^
                                    var