Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-15885] NS_SWIFT_UI_ACTOR isn't recognized on block typedefs #58150

Closed
rjmccall opened this issue Feb 19, 2022 · 4 comments · Fixed by #70693
Closed

[SR-15885] NS_SWIFT_UI_ACTOR isn't recognized on block typedefs #58150

rjmccall opened this issue Feb 19, 2022 · 4 comments · Fixed by #70693
Labels
attributes Feature: Declaration and type attributes bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. clang importer Area → compiler: The clang importer compiler The Swift compiler itself concurrency Feature: umbrella label for concurrency language features good first issue Good for newcomers objective-c interop Feature: Interoperability with Objective-C types Feature: types

Comments

@rjmccall
Copy link
Contributor

Previous ID SR-15885
Radar None
Original Reporter @rjmccall
Type Bug
Additional Detail from JIRA
Votes 1
Component/s
Labels Bug, StarterBug
Assignee None
Priority Medium

md5: c804c21c1b5258c110b8fb340a9361b7

Issue Description:

As reported by Aaron Sky on the forums:

https://forums.swift.org/t/annotate-objective-c-block-type-with-ns-swift-ui-actor/55437

This method ought to be imported as taking and return a @MainActor function type, but doesn't seem to be:

@import Foundation;

typedef void (^FooAction)(void) NS_SWIFT_UI_ACTOR;

@protocol Foo
@property (nonatomic, nullable) FooAction didDoFoo;
- (void)doFoo;
@end
@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@a-alhayek
Copy link

@rjmccall Hi, I would love to take on this issue as my first contribute to swift repo. Where to start on this?

@a-alhayek
Copy link

Some of the test cases are failing
Screen Shot 2022-07-07 at 9 27 48 AM

@wesleykebrown
Copy link

Hi @rjmccall, I'm a part of a software development cohort. I would like to use this issue as my first contribution to swift repo. Which area can I begin in?

@xedin
Copy link
Contributor

xedin commented Jul 24, 2024

Unfortunately this issue has already been fixed by #70693, sorry for the confusion!

@xedin xedin closed this as completed Jul 24, 2024
@AnthonyLatsis AnthonyLatsis added concurrency Feature: umbrella label for concurrency language features objective-c interop Feature: Interoperability with Objective-C compiler The Swift compiler itself clang importer Area → compiler: The clang importer labels Jul 25, 2024
@AnthonyLatsis AnthonyLatsis added attributes Feature: Declaration and type attributes types Feature: types labels Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attributes Feature: Declaration and type attributes bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. clang importer Area → compiler: The clang importer compiler The Swift compiler itself concurrency Feature: umbrella label for concurrency language features good first issue Good for newcomers objective-c interop Feature: Interoperability with Objective-C types Feature: types
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants