Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bootstrapping broken for Ninja builds on Apple silicon Macs (arm64) #62017

Closed
AnthonyLatsis opened this issue Nov 10, 2022 · 3 comments · Fixed by #63381, #63541 or #63440
Closed

Bootstrapping broken for Ninja builds on Apple silicon Macs (arm64) #62017

AnthonyLatsis opened this issue Nov 10, 2022 · 3 comments · Fixed by #63381, #63541 or #63440
Labels
arm Architecture: any ARM arm64 Architecture: arm64 (aarch64) — any 64-bit ARM bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. build cmake macOS Platform: macOS

Comments

@AnthonyLatsis
Copy link
Collaborator

AnthonyLatsis commented Nov 10, 2022 •
edited
Loading

Steps To Reproduce
Build via Ninja on an Apple silicon Mac and spot check your build. Unlike bootstrapping0/bin/swift-frontend, bin/swift-frontend does not get rebuilt and hence does not reflect the change.
@AnthonyLatsis AnthonyLatsis added bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. arm Architecture: any ARM cmake macOS Platform: macOS labels Nov 10, 2022
@AnthonyLatsis AnthonyLatsis changed the title Bootstrapping broken for Ninja builds on Apple Silicon Macs (arm64) Bootstrapping broken for Ninja builds on Apple silicon Macs (arm64) Nov 10, 2022
@AnthonyLatsis AnthonyLatsis mentioned this issue Nov 10, 2022
Merged
@AnthonyLatsis AnthonyLatsis added build arm64 Architecture: arm64 (aarch64) — any 64-bit ARM labels Nov 17, 2022
@eeckstein eeckstein mentioned this issue Feb 2, 2023
Merged
eeckstein added a commit to eeckstein/swift that referenced this issue Feb 2, 2023
@eeckstein
docs: fix info about bootstrapping
ef11448 
swiftlang#62017
@eeckstein
Copy link
Contributor

The problem is that, due to reasons which go beyond my cmake knowledge, ninja swift-frontend doesn't necessarily refer to the bin/swift-frontend executable, but to a bootstrapping swift-frontend.
Using ninja bin/swift-frontend solves the problem. I updated the docs: #63381

@AnthonyLatsis
Copy link
Collaborator Author

@eeckstein Thanks a lot! I didn’t know you could pass a path to an executable, a not a registered target name, to ninja. Is this common practice internally?

@AnthonyLatsis AnthonyLatsis linked a pull request Feb 2, 2023 that will close this issue
docs: fix info about bootstrapping #63381
Merged
@eeckstein
Copy link
Contributor

Is this common practice internally?

I think it depends what you want to do.

AnthonyLatsis added a commit that referenced this issue Feb 9, 2023
@AnthonyLatsis
[docs] GettingStarted: Tweak one more Ninja target suggestion to work…
baab7d2 
… on Apple Silicon

See #62017
@AnthonyLatsis AnthonyLatsis mentioned this issue Feb 9, 2023
Merged
This was linked to pull requests Feb 9, 2023
[docs] GettingStarted: Tweak one more Ninja target suggestion to work on Apple Silicon #63541
Merged
[docs] Suggest ninja bin/swift-frontend instead of ninja swift-frontend #63440
Merged
AnthonyLatsis added a commit that referenced this issue Feb 11, 2023
@AnthonyLatsis
[docs] GettingStarted: Tweak one more Ninja target suggestion to work…
a7517b0 
… on Apple Silicon

See #62017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arm Architecture: any ARM arm64 Architecture: arm64 (aarch64) — any 64-bit ARM bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. build cmake macOS Platform: macOS
Projects
None yet
Milestone
No milestone
2 participants
@eeckstein @AnthonyLatsis