From dd2e3480e23d9cfd7185c97f90822415621f8412 Mon Sep 17 00:00:00 2001 From: Andrew Trick Date: Tue, 30 Jan 2018 10:59:07 -0800 Subject: [PATCH] Add a test case for AST verification of loaded modules in WMO. Prior to the following commit, the SILVerifier will assert on this test case. PR: 14250 commit deebe8b9c7008b2b947b48142dcf9a46d75989fe Author: Andrew Trick Date: Mon Jan 29 15:22:28 2018 performTypeChecking: Defer verifyAllLoadedModules in WMO mode. --- .../Sema/Inputs/rdar36801676.swift | 2 ++ .../Sema/Inputs/rdar36801676_empty.swift | 1 + validation-test/Sema/wmo_verify_loaded.swift | 26 +++++++++++++++++++ 3 files changed, 29 insertions(+) create mode 100644 validation-test/Sema/Inputs/rdar36801676.swift create mode 100644 validation-test/Sema/Inputs/rdar36801676_empty.swift create mode 100644 validation-test/Sema/wmo_verify_loaded.swift diff --git a/validation-test/Sema/Inputs/rdar36801676.swift b/validation-test/Sema/Inputs/rdar36801676.swift new file mode 100644 index 0000000000000..159135d06b52f --- /dev/null +++ b/validation-test/Sema/Inputs/rdar36801676.swift @@ -0,0 +1,2 @@ +import Cocoa +extension Notification.Name {} diff --git a/validation-test/Sema/Inputs/rdar36801676_empty.swift b/validation-test/Sema/Inputs/rdar36801676_empty.swift new file mode 100644 index 0000000000000..d7221f8ec988e --- /dev/null +++ b/validation-test/Sema/Inputs/rdar36801676_empty.swift @@ -0,0 +1 @@ +// Empty swift source file. diff --git a/validation-test/Sema/wmo_verify_loaded.swift b/validation-test/Sema/wmo_verify_loaded.swift new file mode 100644 index 0000000000000..46f31df189991 --- /dev/null +++ b/validation-test/Sema/wmo_verify_loaded.swift @@ -0,0 +1,26 @@ +// RUN: rm -rf %t +// RUN: mkdir -p %t +// RUN: %target-swift-frontend -swift-version 4 -emit-module -o %t/rdar36801676.swiftmodule %S/Inputs/rdar36801676.swift +// RUN: %target-swift-frontend -swift-version 4 -emit-silgen -enable-objc-interop -I %t -emit-silgen %S/Inputs/rdar36801676_empty.swift %s | %FileCheck %s +// REQUIRES: OS=macosx + +// If AST loaded module verification is run after type checking the empty source +// file (rdar36801676_empty.swift), but before type checking this source file, +// then the importer caches the declaration for PasteboardType's constructor +// without synthesizing it's body. Eventually, the SILVerifier will raise a linkage error: +// SIL verification failed: external declarations of SILFunctions with shared +// visibility is not allowed: SingleFunction || +// !hasSharedVisibility(RefF->getLinkage()) || RefF->hasForeignBody() + +import Cocoa +import rdar36801676 + +let objCSynthesizedEnum = NSPasteboard.PasteboardType(rawValue: "MyPboardType") +extension Notification.Name {} + +// NSPasteboardType.init(rawValue:) +// - just make sure it has a body. +// CHECK-LABEL: sil shared [transparent] [serializable] @$SSo16NSPasteboardTypea8rawValueABSS_tcfC : $@convention(method) (@owned String, @thin NSPasteboard.PasteboardType.Type) -> @owned NSPasteboard.PasteboardType { +// CHECK: bb0(%0 : $String, %1 : $@thin NSPasteboard.PasteboardType.Type): +// CHECK: return %{{.*}} : $NSPasteboard.PasteboardType +// CHECK-LABEL: } // end sil function '$SSo16NSPasteboardTypea8rawValueABSS_tcfC'