[AutoDiff] Unify code for differentiation parameter inference. #23350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-zheng
commented
Mar 16, 2019
include/swift/AST/AutoDiff.h
Outdated
Contributor
Author
There was a problem hiding this comment.
Removed setAllParameters because it has no usages and is subsumed by inferParameters.
It would be possible to implement inferParameters using setAllParameters if AutoDiffParameterIndicesBuilder stored a functionType, but it doesn't.
dan-zheng
changed the title
dan-zheng
force-pushed
the
TF-363
branch
2 times, most recently
from
d6cbf87 to
b87d54e
Compare
dan-zheng
commented
Mar 16, 2019
lib/AST/AutoDiff.cpp
Outdated
Contributor
Author
There was a problem hiding this comment.
Note: conformsToDifferentiableInModule is duped in TypeCheckAttr.cpp. It could be declared in AutoDiff.h to eliminate dupe, holding off for now though.
Previously, `@differentiable` attribute type-checking used ad-hoc differentiation parameter inference logic. Now, that differentiation parameter inference logic has been moved to `AutoDiffParameterIndicesBuilder::inferParameters` so that it can be shared with `@differentiable` attribute type-checking. Add retroactive derivative tests. Resolves TF-363.
rxwei
approved these changes
Mar 16, 2019
- Move tests to `test/AutoDiff/derivative_registration.swift`. - Document differentiation parameter inference rules.
Contributor
Author
|
@swift-ci Please test tensorflow |
Contributor
Author
|
@swift-ci Please test tensorflow macOS |
Contributor
Author
|
@swift-ci Please test tensorflow linux GPU |
rxwei
pushed a commit
to rxwei/swift
that referenced
this pull request
May 11, 2019
…lang#23350) Previously, `@differentiable` attribute type-checking used ad-hoc differentiation parameter inference logic. Now, that differentiation parameter inference logic has been moved to `AutoDiffParameterIndicesBuilder::inferParameters` so that it can be shared with `@differentiable` attribute type-checking. Add derivative registration tests. Resolves TF-363.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
@differentiableattribute type-checking used ad-hocdifferentiation parameter inference logic.
Now, that differentiation parameter inference logic has been moved to
AutoDiffParameterIndicesBuilder::inferParametersso that it can be sharedwith
@differentiableattribute type-checking.Add retroactive derivative tests.
Resolves TF-363.