Sema: Prefer an outer type named 'Self' over the SE-0068 behavior [5.2] #29900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a recent source break. We need to perform the normal unqualified lookup before we handle the special case of 'Self', because there might be a type named Self defined in an outer context. Fixes <https://bugs.swift.org/browse/SR-12133> / <rdar://problem/59216636>
Contributor
Author
|
@swift-ci Please test |
slavapestov
changed the title
Contributor
|
Build failed |
Contributor
|
Build failed |
Contributor
Author
|
@swift-ci Please test |
Contributor
|
Build failed |
Contributor
|
Build failed |
tkremenek
approved these changes
Feb 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a recent source break. We need to perform the normal
unqualified lookup before we handle the special case of 'Self',
because there might be a type named Self defined in an outer
context.
Fixes https://bugs.swift.org/browse/SR-12133 / rdar://problem/59216636