[SE-0296] Enable async/await by default. #35784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always parse `async` and `await`, allowing the definition and use of asynchronous functions without the "experimental concurrency" flag. Note that, at present, use of asynchronous functions requires one to explicitly import or link against the `_Concurrency` library. We'll sort this out in a follow-up change. Tracked by rdar://73455330.
Member
Author
|
@swift-ci please smoke test |
Member
Author
|
@swift-ci please smoke test macOS |
Member
Author
|
The LSP failure is a legitimate source break from us trying to be helpful with our |
The way in which we detected an "async" in expression context broke some well-formed code that used "async" as a variable. Narrow the check to only cases where the code will be ill-formed with "async" as an identifier.
Member
Author
|
@swift-ci please smoke test |
Member
Author
|
Err, by "legitimate break" I mean "it's a source compatibility bug and I'm fixing it". |
Member
Author
|
@swift-ci please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always parse
asyncandawait, allowing the definition and use ofasynchronous functions without the "experimental concurrency" flag.
Note that, at present, use of asynchronous functions requires one to
explicitly import or link against the
_Concurrencylibrary. We'llsort this out in a follow-up change.
Tracked by rdar://73455330.