Skip to content

[Gardening] Remove YieldingContinuation since that approach was disfavored to AsyncStream #37504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

phausler
Copy link
Contributor

Remove YieldingContinuation since that was found to be insufficient to accomplish the goals of custom-non-async-sources to be made into AsyncSequences.

Fun fact... this was already removed from the CMakeLists.txt so it wasn't being built! So this is not an ABI breaking change and really just a gardening change ;)

Resolves rdar://78174691

@phausler phausler requested a review from DougGregor May 19, 2021 17:13
@phausler
Copy link
Contributor Author

@swift-ci please smoke test

@DougGregor
Copy link
Member

@swift-ci please smoke test macOS

1 similar comment
@phausler
Copy link
Contributor Author

@swift-ci please smoke test macOS

@DougGregor
Copy link
Member

Fun fact... this was already removed from the CMakeLists.txt so it wasn't being built! So this is not an ABI breaking change and really just a gardening change ;)

It looks like YieldingContinuation.swift is in CMakeLists.txt on the 5.5 branch, though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants