[stdlib] fix an accidental recursion bug involving Collection #38161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
glessard
force-pushed
the
sr14848
branch
2 times, most recently
from
9360ff1
to
f366aba
Compare
|
@swift-ci please smoke test |
lorentey
approved these changes
Jul 1, 2021
- adds a default implementation of Collection’s subscript(bounds: Range<_>) with the most general signature possible - it is marked unavailable in order to prevent the infinite recursion bug reported in SR-14848 - Collections whose SubSequence is Slice<Self> still get the proper default, as intended.
|
@swift-ci please smoke test |
This was referenced Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collection’ssubscript(bounds: Range<_>)with the most general signature possibleSubSequenceisSlice<Self>still get the proper default.Resolves SR-14848