Adopt Sendable in the Task APIs #38866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
ktoso
approved these changes
Aug 13, 2021
|
Welp, looks like I need to fix that compile error. |
DougGregor
force-pushed
the
sendable-task-apis
branch
from
e05f021
to
48e5414
Compare
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
karwa
reviewed
Aug 13, 2021
| @@ -10,7 +10,7 @@ struct S1 { | |||
| var c: C2 | |||
| } | |||
|
|
|||
| enum E1 { | |||
| enum E1 { // expected-note{{add conformance of enum 'E1' to the 'Sendable' protocol}} | |||
There was a problem hiding this comment.
This message is a bit strange. We don’t add conformance of types to protocols. Might I suggest:
add conformance to the ‘Sendable’ protocol to the enum ‘E1’.
or even
add ‘Sendable’ conformance to the enum ‘E1’.
There was a problem hiding this comment.
We use the "consider" wording elsewhere, so I'm going to try out
consider making enum 'E1' conform to the 'Sendable' protocol
Rework Sendable checking to be completely based on "missing" conformances, so that we can individually diagnose missing Sendable conformances based on both the module in which the conformance check happened as well as where the type was declared. The basic rules here are to only diagnose if either the module where the non-Sendable type was declared or the module where it was checked was compiled with a mode that consistently diagnoses `Sendable`, either by virtue of being Swift 6 or because `-warn-concurrency` was provided on the command line. And have that diagnostic be an error in Swift 6 or warning in Swift 5.x. There is much tuning to be done here.
The notes that go along with Codable synthesis were being emitted before the actual "type does not conform" diagnostic, so they would be associated with a prior diagnostic... or dropped on the floor. Queue up the synthesis notes and emit them after the "type does not conform" diagnostic.
DougGregor
force-pushed
the
sendable-task-apis
branch
from
48e5414
to
42c0658
Compare
|
@swift-ci please smoke test |
ghost
approved these changes
Aug 16, 2021
…ormances. Extend the diagnostics for `Sendable` conformances to always diagnose missing `Sendable` conformances for nominal types that are within the same module. The intuition here is that if the type is in the same module, it can be updated and evaluated at the same time as code requiring the `Sendable` conformance is introduced. Another part of rdar://78269348.
This is part of SE-0311 that was not implemented. Fixes rdar://77441933.
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework
Sendablechecking to be completely based on "missing"conformances, so that we can individually diagnose missing
Sendableconformances based on both the module in which the conformance check
happened as well as where the type was declared. The basic rules here
are to only diagnose if the non-
Sendabletype either comes from thecurrent model or from a module that was compiled in a mode that
consistently diagnoses
Sendable. The latter is true for modulescompiled in Swift 6 mode or that provide
-warn-concurrencyonthe command line. This is tracked by rdar://78269348.
The diagnostics will be an error in Swift 6 or a warning in Swift 5.x.
Use this to adopt
Sendablein the Task APIs without breaking code,tracked by rdar://77441933.