[stdlib] Median #39335
Closed
[stdlib] Median #39335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benrimmington
added
the
swift evolution pending discussion
benrimmington
commented
Sep 16, 2021
Comment on lines
-12
to
-21
| // FIXME(prext): remove this conformance. | ||
| extension String.UnicodeScalarView : Equatable {} | ||
|
|
||
| // FIXME(prext): remove this function. | ||
| public func == ( | ||
| lhs: String.UnicodeScalarView, rhs: String.UnicodeScalarView) -> Bool { | ||
| return Array(lhs) == Array(rhs) | ||
| } | ||
|
|
||
| // FIXME(prext): move this struct to the point of use. |
There was a problem hiding this comment.
These lines were leftover by commit 91d1821.
benrimmington
force-pushed
the
median
branch
2 times, most recently
from
2a27bed
to
5759cb3
Compare
NevinBR
reviewed
Sep 22, 2021
benrimmington
force-pushed
the
median
branch
from
5759cb3
to
a6f5ec3
Compare
benrimmington
force-pushed
the
median
branch
from
a6f5ec3
to
cc96174
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposal would add a global
medianfunction to the standard library.Swift-evolution thread: Pitch