SE-0334: Pointer API Usability Improvements #39639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glessard
force-pushed
the
se-pointer-convenience
branch
from
8bf9ae6
to
f3816b7
Compare
glessard
force-pushed
the
se-pointer-convenience
branch
2 times, most recently
from
30599af
to
d9c8327
Compare
glessard
force-pushed
the
se-pointer-convenience
branch
from
d9c8327
to
e89e66e
Compare
glessard
force-pushed
the
se-pointer-convenience
branch
2 times, most recently
from
4c052ef
to
941af40
Compare
glessard
changed the title
|
@swift-ci please smoke test |
glessard
force-pushed
the
se-pointer-convenience
branch
from
941af40
to
b24ae11
Compare
|
@swift-ci please smoke test |
glessard
force-pushed
the
se-pointer-convenience
branch
from
3751fa6
to
1a06919
Compare
|
@swift-ci please smoke test |
glessard
changed the title
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please smoke test macOS platform |
|
@swift-ci please test |
glessard
force-pushed
the
se-pointer-convenience
branch
2 times, most recently
from
5dd16ac
to
3e71a7a
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS platform |
|
@swift-ci please smoke test |
stephentyrone
requested changes
Feb 23, 2022
- The stride check in `UnsafePointer.withMemoryRebound` makes less sense when rebinding memory for a single element. - This skips the stride-matching portion of the `_debugPrecondition` in `withMemoryRebound` when `count == 1`.
glessard
force-pushed
the
se-pointer-convenience
branch
from
f51a6e6
to
dc09862
Compare
|
rebased to resolve merge conflict |
|
@swift-ci please smoke test |
glessard
force-pushed
the
se-pointer-convenience
branch
from
dc09862
to
bb05e85
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of SE-0334, "Pointer API Usability Improvements. See proposal here.
Addresses rdar://64342031, SR-11156 (rdar://53272880), rdar://22541346 and rdar://88087964.