-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SR-15135] Copy over early swift-driver executable to the build dir instead of creating a symlink
#39822
Conversation
|
@swift-ci please test |
|
Build failed |
|
I think this will work, but one problem is that this isn't tested on the linux CI, as there is no prebuilt host toolchain installed on there: |
|
@swift-ci please test macOS platform |
Ah, that's pretty unfortunate. |
77436f9
to
9b3e02c
Compare
|
@swift-ci please test |
|
@compnerd does this look okay to merge? |
|
Yeah, I think that its safe, minor note request, but a follow up is just as fine, no need to wait for the CI times. |
… instead of creating a symlink The SwiftDriver searches `swift-frontend` based on `Bundle.main.executablePath` (which internally uses `CFGetProcessPath`). This search dir is resolved differently on macOS and Linux so swift-frontend can't be found on Linux, forcing the driver to fallback to using the host system toolchain instead of the just-built one.
9b3e02c
to
f842782
Compare
|
@swift-ci please smoke test |
The SwiftDriver searches
swift-frontendbased onBundle.main.executablePath(which internally usesCFGetProcessPath). This search dir is resolved differently on macOS and Linux so swift-frontend can't be found on Linux, forcing the driver to fallback to using the host system toolchain instead of the just-built one.