[build-script] Drop Python2.7 from swift_cmake_options. #42009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Swift is dropping Python2 support, and since this xcrun line causes spurious errors during a build-script build on systems without Python2, I am proposing we drop this xcrun -find line from build-script-impl.
|
@swift-ci please smoke test |
|
This will probably conflict with #41981 |
Ah fantastic. I will close this PR then and wait on the other PR. |
|
I'm not sure if that one is suitable for merging, and if it is it probably won't be quick—it might be better to go ahead with this smaller change, I can handle the conflict. |
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test MacOS Platform |
|
@swift-ci Please test Windows Platform |
1 similar comment
|
@swift-ci Please test Windows Platform |
compnerd
approved these changes
Apr 4, 2022
|
Going to merge since #41981 doesnt seem to be making progress. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Swift is dropping Python2 support, and since this xcrun line causes
spurious errors during a build-script build on systems without Python2,
I am proposing we drop this xcrun -find line from build-script-impl.
@gottesmm