Sema: Remove SwiftUI type witness matching compatibility hack #59795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
force-pushed
the
remove-swiftui-type-witness-hack
branch
from
7d7cfb4
to
c3abc72
Compare
AnthonyLatsis
approved these changes
Jun 30, 2022
|
@slavapestov Why the DNM? |
|
@slavapestov Any updates on this? What are we waiting for? |
|
@AnthonyLatsis The hack is now disabled on main, except when building swiftinterface files. We need to keep it around a while longer since swiftinterface files generated by older compilers don't have all the right synthesized typealiases. |
|
CI is now using Xcode 14.2. I suppose we are ready to proceed? Edit: Aargh! Apparently the fix didn’t make it to 14.2. |
slavapestov
force-pushed
the
remove-swiftui-type-witness-hack
branch
from
c3abc72
to
cc5845f
Compare
|
@swift-ci Please smoke test |
slavapestov
changed the title
|
@swift-ci please smoke test macOS |
1 similar comment
|
@swift-ci please smoke test macOS |
|
Ok, CI is still on 14.2. Bug is fixed in 14.3 |
|
@swift-ci please smoke test |
slavapestov
force-pushed
the
remove-swiftui-type-witness-hack
branch
from
cc5845f
to
4ed1de5
Compare
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that rdar://problem/91451771 is fixed, SwiftUI.swiftinterface should build
without this hack.