[5.7] [Sema] Look through FunctionConversionExpr when finding @discardableResult callee #60386
+13
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: When calling a
@discardableResult @MainActorannotated function, the call to the function is wrapped in an implicitFunctionConversionExpr. The code was not looking through this expression to find the callee function and thus was incorrectly triggering aresult of call to function <name> is unusedwarning. This warning does not trigger on 5.6, so it is a regression in 5.7.Risk: Low, a tiny change to the logic to look through this implicit expression
Review by: @xedin
Testing: PR Testing
Original PR: #60324