[SymbolGraphGen] add new flag to skip "protocol implementation" symbols #63726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdar://59899968
QuietMisdreavus
requested review from
d-ronnqvist,
ethan-kusters,
franklinsch and
daniel-grumberg
|
@swift-ci Please smoke test |
|
@swift-ci Please build toolchain macOS Platform |
|
@swift-ci Please smoke test |
|
@swift-ci Please test |
franklinsch
approved these changes
Feb 20, 2023
| Options.OutputDir = OutputDir; | ||
| Options.Target = Target; | ||
| Options.PrettyPrint = ParsedArgs.hasArg(OPT_pretty_print); | ||
| Options.EmitSynthesizedMembers = !ParsedArgs.hasArg(OPT_skip_synthesized_members); |
There was a problem hiding this comment.
Small nit on the naming here; the 'protocol implementations' one is exclusive (skip) and this one inclusive (emit).
There was a problem hiding this comment.
Right, i wanted to keep the settings field the same name as the CLI flag, to avoid the boolean inversion that -skip-synthesized-members has when applying into EmitSynthesizedMembers
|
@swift-ci Please build toolchain macOS Platform |
1 similar comment
|
@swift-ci Please build toolchain macOS Platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves rdar://59899968
This PR introduces a new flag to affect SymbolGraphGen, available on the frontend and on
swift-symbolgraph-extract:-skip-protocol-implementations. When present, this flag causes SymbolGraphGen to drop symbols that have an "inherited symbol", i.e. that are implementations of protocol requirements or are synthesized copies of protocol extensions. The conformance relationship between the type and the protocol itself remains, so that these relationships can be reconstructed.