Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[interop] add itanium ABI support for trapping on uncaught exceptions when making a foreign call #63809

Merged
merged 14 commits into from
Feb 24, 2023
Merged

[interop] add itanium ABI support for trapping on uncaught exceptions when making a foreign call #63809

merged 14 commits into from
Feb 24, 2023

Conversation

hyp
Copy link
Contributor

@hyp hyp commented Feb 21, 2023 •
edited
Loading

Enabled when C++ interop is enabled, unless Clang args disable exceptions. Still needs MSVC eh support. I'm planning to add it in a follow-up after doing some refactorings in Clang.

@hyp hyp added the c++ interop Feature: Interoperability with C++ label Feb 21, 2023
@hyp
Copy link
Contributor Author

hyp commented Feb 21, 2023

@swift-ci please test

@hyp
Copy link
Contributor Author

hyp commented Feb 21, 2023

@swift-ci please test

@hyp
Copy link
Contributor Author

hyp commented Feb 21, 2023

@swift-ci please test linux platform

@hyp
[interop] test, ensure we do not check for exceptions when exceptions…
7dbfc51 
… are also disabled
@hyp
[interop] test, add tests that function pointers called from Swift tr…
fd3e784 
…ap on uncaught exceptions
@hyp
[interop] test, add test to ensure that a protocol conformance witnes…
a259a20 
…s can trap on uncaught exceptions
@hyp
[interop] test, add a test for trapping on exception in transparent t…
613e545 
…hunk in Swift
@hyp
[interop] test, runtime test for protocol witness / thunk trap on unc…
7801adf 
…aught exception
@hyp
[interop] test, add an Objective-C method invocation exception trappi…
56ee7c5 
…ng test
@hyp
[interop] trap on uncaught C++ destructor exceptions
7d8ecfc
@hyp
[interop] trap on uncaught C++ copy constructor exceptions
8998f97
@hyp
[interop] ensure that call to a C++ constructor traps on uncaught exc…
355f00c 
…eption
@hyp
[interop] ignore exceptions in existing interop tests
9feb764
@hyp
Copy link
Contributor Author

hyp commented Feb 22, 2023

@swift-ci please test

@hyp hyp changed the title [interop] add initial support for trapping on uncaught exceptions when making a foreign call [interop] add itanium ABI support for trapping on uncaught exceptions when making a foreign call Feb 22, 2023
@hyp
Copy link
Contributor Author

hyp commented Feb 22, 2023

@swift-ci please test

@hyp
Copy link
Contributor Author

hyp commented Feb 22, 2023

@swift-ci please test source compatibility

@hyp
Copy link
Contributor Author

hyp commented Feb 23, 2023

@swift-ci please test macOS

@hyp
Copy link
Contributor Author

hyp commented Feb 23, 2023

@swift-ci please test source compatibility

@hyp
Copy link
Contributor Author

hyp commented Feb 23, 2023

@swift-ci please test

@hyp
Copy link
Contributor Author

hyp commented Feb 23, 2023

@swift-ci please test source compatibility

@hyp
Copy link
Contributor Author

hyp commented Feb 23, 2023

@swift-ci please test linux platform

@hyp
Copy link
Contributor Author

hyp commented Feb 23, 2023

@swift-ci please build toolchain

@hyp
Copy link
Contributor Author

hyp commented Feb 23, 2023

@swift-ci please test linux platform

@hyp
Copy link
Contributor Author

hyp commented Feb 23, 2023

the source compat failures are unrelated (#63869)

@hyp
[interop] test, ensure we call copy-constructor when optimizations ar…
e704e94 
…e enabled in trap-on-exception-execution.swift
@hyp
Copy link
Contributor Author

hyp commented Feb 23, 2023

@swift-ci please test

@hyp
Copy link
Contributor Author

hyp commented Feb 23, 2023

@swift-ci please test source compatibility

@hyp hyp merged commit fedf86f into swiftlang:main Feb 24, 2023
@finagolfin
Copy link
Contributor

@hyp, it appears this broke a couple of these tests on the Android AArch64 CI, do we just need to add -Xcc -fignore-exceptions for those Android tests too, like you did for macOS?

@hyp
Copy link
Contributor Author

hyp commented Mar 1, 2023

@buttaface yes, please add -Xcc -fignore-exceptions for these failing tests. That should fix them.

finagolfin added a commit to finagolfin/swift that referenced this pull request Mar 7, 2023
@finagolfin
[android][test] Fix two C++ Interop tests that were recently updated …
9e3492c 
…on macOS

These flags were recently added to the macOS versions of these tests in swiftlang#63809.
@finagolfin finagolfin mentioned this pull request Mar 7, 2023
Merged
@hyp hyp mentioned this pull request Mar 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoecarver zoecarver Awaiting requested review from zoecarver zoecarver is a code owner

@egorzhdan egorzhdan Awaiting requested review from egorzhdan egorzhdan is a code owner

Assignees
No one assigned
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hyp @finagolfin