Skip to content

[Basic] MaxMallocUsage statistic should cover all zones #68412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2023
Merged

[Basic] MaxMallocUsage statistic should cover all zones #68412

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/Basic/Statistic.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,7 +530,8 @@ void updateProcessWideFrontendCounters(
// On Darwin we have a lifetime max that's maintained by malloc we can
// just directly query, even if we only make one query on shutdown.
malloc_statistics_t Stats;
malloc_zone_statistics(malloc_default_zone(), &Stats);
// Query all zones.
malloc_zone_statistics(/*zone=*/NULL, &Stats);
C.MaxMallocUsage = (int64_t)Stats.max_size_in_use;
#else
// If we don't have a malloc-tracked max-usage counter, we have to rely
Expand Down