6.0: [TypeLowering] Return pseudogeneric @autoreleasing. #74131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when a pseudogeneric function returned a type parameter, it was unowned. That resulted in invalid OSSA out of SILGen. Here, this is fixed to use the @autoreleasing convention. rdar://64375208
nate-chandler
requested review from
a team,
hborla,
slavapestov,
xedin,
ahoppen,
bnbarham,
rintaro,
hamishknight,
shahmishal,
mikeash,
al45tair,
compnerd,
adrian-prantl,
AnthonyLatsis,
QuietMisdreavus,
kavon,
artemcm,
CodaFi,
DougGregor,
zoecarver,
hyp,
egorzhdan,
MaxDesiatov,
etcwilde,
ktoso,
phausler,
tshortli,
beccadax and
ian-twilightcoder
as code owners
nate-chandler
removed request for
ktoso,
rintaro,
kavon,
phausler,
mikeash,
etcwilde,
hyp,
beccadax,
DougGregor,
bnbarham,
CodaFi,
adrian-prantl,
shahmishal,
al45tair,
egorzhdan,
ahoppen,
QuietMisdreavus,
artemcm,
hborla,
zoecarver,
ian-twilightcoder,
hamishknight,
eeckstein,
tshortli and
AnthonyLatsis
|
@swift-ci please test |
tbkka
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Fix a leak in certain Swift extensions of pseudogeneric ObjC types.
Given a pseudogeneric Objective-C type
it's permitted to write an extension in Swift which returns the pseudogeneric parameter
which can be called from ObjC. To match Objective-C conventions, these methods should return values autoreleased.
Previously, these methods returned values unowned. The result was a memory leak and a corresponding SIL verification error.
Here, this is fixed by using the
@autoreleasedconvention in such cases.Scope: Affects extensions of pseudogeneric ObjC types.
Issue: rdar://64375208
Original PR: #74072
Risk: Low.
Testing: Enabled SIL verification in existing test.
Reviewer: Andrew Trick ( @atrick )