[6.0][Concurrency] Don't attempt to diagnose GlobalConcurrency issues wi…
#74624
+44
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th deserialized variable/properties If the property comes from a different module the compiler shouldn't attempt to diagnose `GlobalIsolation` problems based in the current module flags otherwise it would create issues when i.e. a variable/property from a module built with `-swift-version 5` that gets referenced by a module that is built with `-swift-version 6` that has stricter local concurrency requirements. See https://forums.swift.org/t/swift-6-language-mode-being-passed-to-dependencies/72622 for further discussion. A better solution would be to move the check to `ActorIsolationChecker` or `DeclChecker` but that would be too risky for 6.0. (cherry picked from commit aae15c3)
|
@swift-ci please test |
hborla
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…th deserialized variable/properties
Explanation:
If the property comes from a different module the compiler shouldn't attempt to diagnose
GlobalConcurrencyproblems based in the current module flags otherwise it would create issues when i.e. a variable/property
from a module built with
-swift-version 5that gets referenced by a module that is built with-swift-version 6that has stricter local concurrency requirements.
See https://forums.swift.org/t/swift-6-language-mode-being-passed-to-dependencies/72622 for further discussion.
A better solution would be to move the check to
ActorIsolationCheckerorDeclCheckerbut that would be too risky for 6.0.Main Branch PR: [Concurrency] Don't attempt to diagnose
GlobalConcurrencyissues wi… #74614Risk: Very Low
Reviewed By: @hborla
Testing: Existing test-cases were modified and new tests were added.
(cherry picked from commit aae15c3)