Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.0] Disable warning about @preconcurrency having no effect on an import #75365

Conversation

DougGregor
Copy link
Member

@DougGregor DougGregor commented Jul 19, 2024

  • Explanation: We have a couple of persistent issues where the warning about
    @preconcurrency having no effect on import declarations is emitted
    but is wrong, because removing the @preconcurrency will cause
    warnings or errors to appear. Disable this warning until we can make
    it reliable.
    • Scope: Disables a bit of code that generates the warning in concurrency type checking.
    • Original PRs: None, this is only for the 6.0 branch.
    • Issue: rdar://132092532
    • Risk: Very very low. We're just disabling a warning.
    • Testing: Updated tests.

We have a couple of persistent issues where the warning about
`@preconcurrency` having no effect on import declarations is emitted
but is wrong, because removing the `@preconcurrency` will cause
warnings or errors to appear. Disable this warning until we can make
it reliable.
@DougGregor DougGregor requested a review from a team as a code owner July 19, 2024 05:48
@DougGregor
Copy link
Member Author

@swift-ci please test

@DougGregor DougGregor merged commit 3f16623 into swiftlang:release/6.0 Jul 19, 2024
5 checks passed
@DougGregor DougGregor deleted the disable-preconcurrency-import-no-effect-warning-6.0 branch July 19, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants