-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[update-checkout] Add swift-toolchain-sqlite to the list of repos #75743
Conversation
|
@swift-ci please smoke test |
| @@ -173,6 +176,7 @@ | |||
| "swift": "release/6.0", | |||
| "cmark": "release/6.0", | |||
| "llbuild": "release/6.0", | |||
| "swift-toolchain-sqlite": "release/6.0", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll defer to @shahmishal if it makes sense to include these in the release branch schemes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we should branch these as otherwise we will not be able to reproduce the builds when we update the repository.
| @@ -173,6 +176,7 @@ | |||
| "swift": "release/6.0", | |||
| "cmark": "release/6.0", | |||
| "llbuild": "release/6.0", | |||
| "swift-toolchain-sqlite": "release/6.0", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we should branch these as otherwise we will not be able to reproduce the builds when we update the repository.
| @@ -224,6 +228,7 @@ | |||
| "swift": "release/5.10", | |||
| "cmark": "release/5.10", | |||
| "llbuild": "release/5.10", | |||
| "swift-toolchain-sqlite": "release/5.10", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will we back-fill the release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created the branches for 6.0 and 5.10 on the repo, not sure if there's more to do than that.
|
Overall, the changes looks good. However, we should not include the |
This is for swiftlang/swift-llbuild#930, which adds swift-toolchain-sqlite as a new dependency to SwiftPM to better support Windows and other platforms.
b2a89cb
to
d87ef2a
Compare
|
@swift-ci please smoke test |
This is for swiftlang/swift-llbuild#930, which adds swift-toolchain-sqlite as a new dependency to SwiftPM to better support Windows and other platforms.