Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[update-checkout] Add swift-toolchain-sqlite to the list of repos #75743

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

jakepetroules
Copy link
Contributor

This is for swiftlang/swift-llbuild#930, which adds swift-toolchain-sqlite as a new dependency to SwiftPM to better support Windows and other platforms.

@jakepetroules
Copy link
Contributor Author

@swift-ci please smoke test

@@ -173,6 +176,7 @@
"swift": "release/6.0",
"cmark": "release/6.0",
"llbuild": "release/6.0",
"swift-toolchain-sqlite": "release/6.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll defer to @shahmishal if it makes sense to include these in the release branch schemes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we should branch these as otherwise we will not be able to reproduce the builds when we update the repository.

@@ -173,6 +176,7 @@
"swift": "release/6.0",
"cmark": "release/6.0",
"llbuild": "release/6.0",
"swift-toolchain-sqlite": "release/6.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we should branch these as otherwise we will not be able to reproduce the builds when we update the repository.

@@ -224,6 +228,7 @@
"swift": "release/5.10",
"cmark": "release/5.10",
"llbuild": "release/5.10",
"swift-toolchain-sqlite": "release/5.10",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will we back-fill the release?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created the branches for 6.0 and 5.10 on the repo, not sure if there's more to do than that.

@shahmishal
Copy link
Member

Overall, the changes looks good. However, we should not include the swift-toolchain-sqlite part of release/5.10 and release/6.0 schemes until we start using the repo.

This is for swiftlang/swift-llbuild#930, which adds swift-toolchain-sqlite as a new dependency to SwiftPM to better support Windows and other platforms.
@jakepetroules
Copy link
Contributor Author

@swift-ci please smoke test

@jakepetroules jakepetroules merged commit 5482b47 into main Aug 7, 2024
3 checks passed
@jakepetroules jakepetroules deleted the update-checkout-sqlite branch August 7, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants