Skip to content

Revert "Builtin.FixedArray" #77201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Revert "Builtin.FixedArray" #77201

wants to merge 1 commit into from

Conversation

@MaxDesiatov
Copy link
Contributor

Reverts #76831 due to failing Wasm job

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test webassembly

@MaxDesiatov
Copy link
Contributor Author

@swift-ci smoke test

@MaxDesiatov MaxDesiatov added WebAssembly Platform: WebAssembly bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. WASI WebAssembly System Interface support IRGen LLVM IR generation SIL labels Oct 24, 2024
@MaxDesiatov MaxDesiatov marked this pull request as ready for review October 24, 2024 14:19
@Azoy
Copy link
Contributor

Azoy commented Oct 24, 2024

Can you link the failing job?

@xedin xedin removed their request for review October 24, 2024 18:38
@aschwaighofer
Copy link
Contributor

https://ci.swift.org/job/oss-swift-pr-test-crosscompile-wasm-ubuntu-20_04/1730/

@aschwaighofer
Copy link
Contributor

It is possible that @jckarter is trying to fix this issue here: #77205

@jckarter
Copy link
Contributor

I merged #77205 to fix this. The lit test should just need some minor adjustments and that would be easier than reverting it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kateinoigakukun kateinoigakukun Awaiting requested review from kateinoigakukun

@hborla hborla Awaiting requested review from hborla hborla is a code owner

@slavapestov slavapestov Awaiting requested review from slavapestov slavapestov is a code owner

@eeckstein eeckstein Awaiting requested review from eeckstein eeckstein is a code owner

@jckarter jckarter Awaiting requested review from jckarter jckarter is a code owner

@rjmccall rjmccall Awaiting requested review from rjmccall rjmccall is a code owner

@mikeash mikeash Awaiting requested review from mikeash mikeash is a code owner

@al45tair al45tair Awaiting requested review from al45tair al45tair is a code owner

@xymus xymus Awaiting requested review from xymus xymus is a code owner

@AnthonyLatsis AnthonyLatsis Awaiting requested review from AnthonyLatsis AnthonyLatsis is a code owner

@adrian-prantl adrian-prantl Awaiting requested review from adrian-prantl adrian-prantl is a code owner

@tshortli tshortli Awaiting requested review from tshortli tshortli is a code owner

Assignees

No one assigned

Labels

bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. IRGen LLVM IR generation SIL WASI WebAssembly System Interface support WebAssembly Platform: WebAssembly

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MaxDesiatov @Azoy @aschwaighofer @jckarter