utils: cleanup Invoke-Program in build.ps1. #79855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
approved these changes
Mar 8, 2025
| [string] $OutFile = "", | ||
| [string] $ErrorFile = "", | ||
| [Parameter(Position = 1, ValueFromRemainingArguments)] | ||
| [string[]] $Args | ||
| [string[]] $ExecutableArgs |
| [Parameter(Position = 0, Mandatory = $true)] | ||
| [string] $Executable, | ||
| [switch] $OutNull = $false, | ||
| [switch] $Silent, | ||
| [switch] $OutNull, |
There was a problem hiding this comment.
Hmm, shouldn't this be the same as -Silent.
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for more changes in this function.
$Argssince it conflicts with a built-in automatic variable of the same name.-Silentwhich will redirect all output at the invocation point (rather than callers using*>when callingInvoke-Program.ToBatchlogic. Ideally we'd cleanup the actual call in a similar way, but as soon as we useInvoke-Expressioninstead of&escaping/quoting of args starts to break.