[6.2] [Strict memory safety] Improve handling of safe types nested within unsafe ones #80946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
DougGregor
commented
Apr 21, 2025
DougGregor
commented
- Explanation: Fix a number of issues related to strict memory safety's handling of safe types nested within unsafe ones, eliminating a class of false positives observed in the adoption of strict memory safety. Previously, we would effectively consider the safe nested type as unsafe if its outer type was unsafe. Model them more independently.
- Scope: Affects diagnostics under the strict memory safety mode introduced by SE-0458.
- Issues: rdar://149628760
- Original PRs: [Strict memory safety] Improve handling of safe types nested within unsafe ones #80933
- Risk: Low. Only affects opt-in diagnostics that are warnings.
- Testing: New tests, updated standard library
Typealiases involving unsafe types that resolve to safe types should not be diagnosed. (cherry picked from commit 0405f61)
…rd libraries Now that we aren't propagating "unsafe" to nested types, remove unnecessary "unsafe" keywords from the standard library. (cherry picked from commit fe68567)
…eir enclosing type When determining whether a nested type is safe, don't consider whether its enclosing type is safe. They're independent. (cherry picked from commit 8ec52c8)
…rlying type is (cherry picked from commit 53ca902)
…as implicitly 'unsafe' This eliminates stray warnings. (cherry picked from commit b7d41a5)
(cherry picked from commit 1c9875e)
Member
Author
|
@swift-ci please test |
nkcsgexi
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.