[cxx-interop] Import complex macros consistently in C++ language mode #84260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egorzhdan
requested review from
Xazax-hun,
beccadax,
fahadnayyar,
hnrklssn,
ian-twilightcoder,
j-hui,
susmonteiro and
zoecarver
as code owners
This is similar to ced4cb0. Clang stores macro information for each identifier inside of `IdentifierInfo`, which can sometimes get outdated. Clang solves this by updating the identifier info if necessary in `getLeafModuleMacros`. Let's do the same in Swift. This makes sure that macros that reference other macros are correctly imported with C++ interop enabled. rdar://145584369 rdar://110071334
egorzhdan
force-pushed
the
egorzhdan/macro-out-of-date
branch
from
0ce9b3f to
3c82042
Compare
Contributor
Author
|
@swift-ci please smoke test |
Xazax-hun
approved these changes
Sep 12, 2025
j-hui
approved these changes
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to ced4cb0.
Clang stores macro information for each identifier inside of
IdentifierInfo, which can sometimes get outdated. Clang solves this by updating the identifier info if necessary ingetLeafModuleMacros. Let's do the same in Swift.This makes sure that macros that reference other macros are correctly imported with C++ interop enabled.
rdar://145584369
rdar://110071334